-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare tests for impending knative/pkg version bump #5145
Conversation
knative/pkg#2548 changes pkg/changeset.Get to read VCS information from information embedded by the Go compiler into built binaries, instead of relying on the convention that a kodata/HEAD symlink exists pointing to the repo's .git/HEAD, and a kodata/refs points to .git/refs. This fails in tests though, since tests don't stamp this information into the binary where it can be read. This change removes our tests' usage of changeset.Get and instead replaces those fake commit SHAs with more obviously placeholder values. It doesn't seem that the tests cared that it was an actual SHA, let along the actual current SHA, they just needed any value that looked like a SHA.
Note to self: After knative/pkg#2548 merges and we pick it up, we can also remove
and Line 76 in 8a7b0cf
and and |
Flake /test pull-tekton-pipeline-alpha-integration-tests |
|
You'll want to bump go.mod's go version to |
/lgtm |
@dprotaso: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The version in Our release process seems to already be using an image based on Go 1.18, here: Line 118 in 8a7b0cf
The Go inside that image is Go 1.18.1, which should work just fine for this change. (That's not to say updating the go version in |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will this have any implications for running tests, Also, we've got Go 1.17.x on a bunch of our images, such as here in ...which I'd assume we'll need to bump to Go 1.18.x as well? |
To reiterate, the version in The only version of Go that matters when we build is the version of the The test-runner image and anything else using 1.17 should be updated soon -- Go 1.19 will be out soon, which means 1.17 will no longer be supported. |
Gotcha, so we should be upgrading |
/lgtm |
knative/pkg#2548 changes pkg/changeset.Get to
read VCS information from information embedded by the Go compiler into
built binaries, instead of relying on the convention that a kodata/HEAD
symlink exists pointing to the repo's .git/HEAD, and a kodata/refs
points to .git/refs.
This fails in tests though, since tests don't stamp this information
into the binary where it can be read.
This change removes our tests' usage of changeset.Get and instead
replaces those fake commit SHAs with more obviously placeholder values.
It doesn't seem that the tests cared that it was an actual SHA, let
along the actual current SHA, they just needed any value that looked
like a SHA.
/kind cleanup
/assign @vdemeester
/assign @abayer
/release-note-none
cc @dprotaso
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
PR friction log:
release-note
-- was this intentional?