Fail validation for PipelineRun params with results in value #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes tektoncd#5271 To prevent confusion, we should reject `PipelineRun` parameter values containing task result references, like `$(tasks.some-task.results.someResult)`, since such values will not have any substitution performed on them. Additionally, we weren't doing the basic parameter validation for `PipelineRun`s that we have been doing for `TaskRun`s, namely checking for duplicate names and use of object params without `alpha` being set, so let's turn that on here as well. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
the
release-note
|
/cc @pritidesai |
tekton-robot
added
the
size/L
pritidesai
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
thank you @abayer for adding restriction such that pipelineRun params cannot use a task result reference as a value 👍
This will not prevent a reference to pipelineRun result but I think it should not be a concern at this point.
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #5271
To prevent confusion, we should reject
PipelineRunparameter values containing task result references, like$(tasks.some-task.results.someResult), since such values will not have any substitution performed on them. Additionally, we weren't doing the basic parameter validation forPipelineRuns that we have been doing forTaskRuns, namely checking for duplicate names and use of object params withoutalphabeing set, so let's turn that on here as well./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes