TEP-0114: Tests Wait Custom Task without CRD in PipelineRun

[XinruZhang]

Changes

This commit starts to test the behavior of Custom Task Run without
CRD in a PipelineRun against a Custom Task Controller.

Future Work: test Custom Task Run with CRD against the Wait Custom
Task Controller.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[jerop]

/assign

[lbernick]

I'm a bit confused what the goal of these tests are-- what do you mean by with/without CRD? The name of the test class is "TestWaitCustomTask_PipelineRun" but the the test cases are PipelineRun running/succeeded/timed out and it seems like it's testing interaction between pipelinerun timeout and wait task duration. Could you please just give a few sentences about what the behavior being tested is?

[XinruZhang]

I'm a bit confused what the goal of these tests are-- what do you mean by with/without CRD? The name of the test class is "TestWaitCustomTask_PipelineRun" but the the test cases are PipelineRun running/succeeded/timed out and it seems like it's testing interaction between pipelinerun timeout and wait task duration. Could you please just give a few sentences about what the behavior being tested is?

Thanks for the comment Lee @lbernick, great point. I think the main purpose is to test how the run status is reflected upon different PipelineRun statuses. I'll update the testing name to make it clearer.

About with/without CRD, the difference is whether the Custom Task has it's own spec&status defined. We can take the existing wait-task controller as an example, we only need to specify apiversion, kind and an input param duration to make it work. The wait.testing.tekton.dev/v1alpha1/Wait doesn't have its own spec and status fields. Therefore the Run status doesn't change upon Wait.status changes.

Shortly speaking, we want to mimic the actual usage of Custom Task Run.

wdyt? Let me know there's still confusion :)

[jerop]

@lbernick @XinruZhang adding a comment to clarify further.

There are some Custom Tasks that don't define CRDs - they are only used inline in Runs and PipelineRuns - these are referred to as "unnamed" Custom Tasks in TEP-0002. Examples of these are Wait and CEL.

There are some Custom Tasks that define CRDs e.g. TaskLoop and PipelineLoop.

These end-to-end tests cover the first scenario (without CRDs) and this may be sufficient for now. If needed later, we may consider adding another Custom Task for testing that covers the second scenario.

[jerop]

Thanks @XinruZhang!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lbernick]

ok thanks @XinruZhang @jerop for the explanation, this makes sense.

/lgtm