Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0114: Timeout the Testing Wait Custom Task #5389

Merged
merged 1 commit into from
Sep 6, 2022
Merged

TEP-0114: Timeout the Testing Wait Custom Task #5389

merged 1 commit into from
Sep 6, 2022

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Aug 29, 2022 •
edited
Loading

Implements Timeout of the Testing Wait Custom Task

Prior to this PR, the testing custom task wait-task, under test/wait-task,
can only wait for a duration of time. This PR adds a new functionality
timeout to its controller, so that we can test the behavior of Custom
Task Run time out.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2022
@tekton-robot tekton-robot requested review from dibyom and dlorenc August 29, 2022 14:15
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2022
@XinruZhang
Copy link
Member Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2022
@abayer
Copy link
Contributor

abayer commented Aug 29, 2022

/retest

Docker Hub is having issues.

@XinruZhang XinruZhang mentioned this pull request Aug 29, 2022
Closed
@XinruZhang XinruZhang changed the title [TEP-114] Timeout Wait Custom Task TEP-0114: Timeout Wait Custom Task Aug 29, 2022
@XinruZhang XinruZhang force-pushed the ctb-timeout branch 2 times, most recently from 210f74b to 44dcbc3 Compare August 29, 2022 16:23
@dibyom
Copy link
Member

dibyom commented Aug 29, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@lbernick lbernick self-assigned this Aug 29, 2022
@XinruZhang
Copy link
Member Author

/hold compare the actual run and expected run.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022
@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
lbernick
lbernick reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should refer to this as the "testing" custom task controller or something similar-- this will help distinguish it from the wait task in experimental that users can install independently and make it clear that the sole purpose of this controller is for testing

test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler_test.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
@XinruZhang XinruZhang force-pushed the ctb-timeout branch 2 times, most recently from c74024e to 2d5a865 Compare August 30, 2022 17:14
@XinruZhang XinruZhang changed the title TEP-0114: Timeout Wait Custom Task TEP-0114: Timeout the Testing Wait Custom Task Aug 30, 2022
@XinruZhang
Copy link
Member Author

XinruZhang commented Aug 30, 2022 •
edited
Loading

I think we should refer to this as the "testing" custom task controller or something similar-- this will help distinguish it from the wait task in experimental that users can install independently and make it clear that the sole purpose of this controller is for testing

SG! Updated the PR Title, description, commit message to clarify it.

lbernick
lbernick approved these changes Aug 31, 2022
View reviewed changes
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@XinruZhang
Copy link
Member Author

/retest

@abayer
Copy link
Contributor

abayer commented Sep 1, 2022

Could you rename test/wait-task to test/custom-task-for-testing or test/testing-wait-task or whatever as well?

@XinruZhang
Copy link
Member Author

Could you rename test/wait-task to test/custom-task-for-testing or test/testing-wait-task or whatever as well?

@abayer Thanks for your comment! I feel the naming testing under folder test/ is a little bit redundant, but I guess I get your point here, it can be better if we clarify that this is a custom task controller. What about creating a new folder called custom-task-controllers, custom-task-ctrls for short, and moving wait-task in it?

@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

@XinruZhang Yeah, that'd be fine - I just didn't want it to be wait-task on its own.

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XinruZhang
TEP-0114: Implements Timeout of the Testing Wait Custom Task
acdb922 
Prior to this commit, the testing custom task wait-task, under test/wait-task,
can only wait for a duration of time. This commit adds a new functionality
timeout to its controller, so that we can test the behavior of Custom
Task Run time out.
@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@XinruZhang
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit c5ce8b3 into tektoncd:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@jerop jerop jerop approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@abayer abayer

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XinruZhang @abayer @dibyom @tekton-robot @jerop @lbernick