Allow user to specify only tasks or finally timeout #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/bug
tekton-robot
added
the
size/M
This commit updates PipelineRun validation to allow a user to specify only a tasks timeout or only a finally timeout. Prior to this commit, if a user wanted to specify no Pipeline timeout (i.e. timeouts.pipeline = 0), they would not be able to specify values for the other timeouts fields.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pritidesai
reviewed
Sep 9, 2022
| pipeline: "0" # No timeout | ||
| finally: "0h3m0s" | ||
| ``` | ||
|
|
||
| You can also use the *Deprecated* `timeout` field to set the `PipelineRun's` desired timeout value in minutes. | ||
| If you do not specify this value in the `PipelineRun`, the global default timeout value applies. | ||
| If you set the timeout to 0, the `PipelineRun` fails immediately upon encountering an error. |
There was a problem hiding this comment.
thanks @lbernick for the fix!
Does this statement still hold true? This is documented in the next paragraph.
If you set the timeout value or timeouts.pipeline to 0, the PipelineRun fails immediately upon encountering an error.
There was a problem hiding this comment.
Yes, this should still be correct, thanks for checking!
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit updates PipelineRun validation to allow a user to specify only a tasks timeout or only a finally timeout.
Prior to this commit, if a user wanted to specify no Pipeline timeout (i.e. timeouts.pipeline = 0), they would not be able to specify values for the other timeouts fields.
Closes #5459.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes