Fail linting if k8s.io/apimachinery/pkg/util/clock is imported #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, suggest using k8s.io/utils/clock or k8s.io/utils/clock/testing. Prompted by tektoncd#5448 and tektoncd#5494 Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
|
Note that |
|
/assign @lbernick @jerop @afrittoli @vdemeester |
|
/approve |
tekton-robot
added
the
approved
|
/retest |
vdemeester
approved these changes
Sep 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
@abayer Sorry for the follow up ping. Would it be possible to also upgrade knative.dev/pkg in the go mod to incorporate their changes for updating the clock library location? (knative/pkg#2589) Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead, suggest using k8s.io/utils/clock or k8s.io/utils/clock/testing.
Prompted by #5448 and #5494
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes