Apply replacements to workspace subpath for finally tasks #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tektoncd#5571 When tektoncd#4351 was done, it didn't do workspace subpath replacement for `finally` tasks as well. This corrects that. Note - `propagateParams` also isn't called for `finally` tasks, but I'm not sure if that's by design, so I left it as is. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
The following is the coverage report on the affected files.
|
|
/retest |
vdemeester
approved these changes
Sep 28, 2022
tekton-robot
added
the
approved
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abayer thanks for noting this - this was not by design, @chitrangpatel opened #5588 which is fixed in #5593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #5571
When #4351 was done, it didn't do workspace subpath replacement for
finallytasks as well. This corrects that.Note -
propagateParamsalso isn't called forfinallytasks, but I'm not sure if that's by design, so I left it as is./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes