tekton: do not fail on git status -s
#5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out, `git status -s` fails if the working directory is a "detached" head, which is what happens in our case. This removes that checks as it renders `pipeline` not releasable at all. It also "locally" tag it to the specified version so that it will appear in the go build metadata. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
abayer
approved these changes
Oct 3, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/cherrypick release-v0.40.x (Just in case we have to do a 0.40.3 🙃 ) |
|
@vdemeester: new pull request created: #5590 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It turns out,
git status -sfails if the working directory is a "detached" head, which is what happens in our case. This removes that checks as it renderspipelinenot releasable at all.It also "locally" tag it to the specified version so that it will appear in the go build metadata.
Signed-off-by: Vincent Demeester [email protected]
/kind misc
/cc @afrittoli @abayer @imjasonh
Note: I used this to release 0.40.2 already 🙃
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes