Remove logsURL from step status
#563
Conversation
In tektoncd#549 @hrishin pointed out that it's hard to understand from the step status exactly which step did what. While looking at this I realized that we have included a field `logsURL` which we never populate - I thought this was copied over from Build but it was actually from our original prototype API and we have never used it. In #107 we should be revisiting making logs available and we may add in something like this, but since we're not using it and it's not clear if we ever will, let's remove it for now.
googlebot
added
the
cla: yes
knative-prow-robot
added
size/M
|
/test pull-knative-build-pipeline-integration-tests |
|
Looks like the e2e test failed to update cancel status. This error has not been encountered so far |
|
@bobcatfish : test failure link is 404. Thats weird |
|
/test pull-knative-build-pipeline-integration-tests |
Interesting, is this new ? 🤔 maybe because of parallel execution of tests ? |
|
/test pull-knative-build-pipeline-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, shashwathi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester : Parallel execution across diff namespaces so I would not expect this error. Looks like between |
I've seen that a couple times too @shashwathi @vdemeester - judging by the linting warnings I get in my editor when I open cancel_test.go I think there might be a couple bugs lurking in there... |
In #549 @hrishin pointed out that it's hard to understand from the step
status exactly which step did what. While looking at this I realized
that we have included a field
logsURLwhich we never populate - Ithought this was copied over from Build but it was actually from our
original prototype API and we have never used it. In #107 we should be
revisiting making logs available and we may add in something like this,
but since we're not using it and it's not clear if we ever will, let's
remove it for now.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
tests
(if functionality changed/added) (n/a)
docs
(if user facing) (n/a)
practices
See the contribution guide
for more details.
Release Notes