Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PipelineRun Example for Creating a Wait CustomRun #5906

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Dec 21, 2022

Changes

Prior to this PR, this wait test controller package only has an example for creating a standalone custom task. This PR creates an example pipelinerun that will create a Beta version of the Wait task.

/kind feature
/close #5754

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Prior to this commit, this test controller package only has an
example for creating a standalone custom task. This commit creates
an example pipelinerun that will create a Beta version of the Wait
task.
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Dec 21, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 21, 2022
@XinruZhang XinruZhang changed the title Add a PipelineRun Example for Creating a CustomRun Add a PipelineRun Example for Creating a Wait CustomRun Dec 21, 2022
@XinruZhang
Copy link
Member Author

/assign @jerop

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@jerop
Copy link
Member

jerop commented Dec 21, 2022

cc @abayer

@jerop jerop added this to the Pipelines v0.43 milestone Dec 21, 2022
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@tekton-robot tekton-robot merged commit b994966 into tektoncd:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEP-0121: Example code for v1beta1.CustomRun
4 participants