-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a PipelineRun Example for Creating a Wait CustomRun #5906
Conversation
Prior to this commit, this test controller package only has an example for creating a standalone custom task. This commit creates an example pipelinerun that will create a Beta version of the Wait task.
/assign @jerop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @abayer |
/lgtm |
Changes
Prior to this PR, this wait test controller package only has an example for creating a standalone custom task. This PR creates an example pipelinerun that will create a Beta version of the Wait task.
/kind feature
/close #5754
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Has Docs included if any changes are user facingHas Tests included if any functionality added or changedfunctionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease notes contains the string "action required" if the change requires additional action from users switching to the new releaseRelease Notes