-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove Artifacts Package #6096
Conversation
Skipping CI for Draft Pull Request. |
@JeromeJu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have been trying to cleanup the artifacts first before moving the entire chunk of storage resources. Some questions I encountered during the cleanup:
|
I think artifacts are probably required for the storage resource to work correctly (although haven't looked into this thoroughly), so removing artifacts before removing storage resources would put us in an unreleasable state. |
Thanks for the instant replies. If this is not preferred then let's remove both storage resources and artifacts in one shot. |
Given that this is already a large PR, I'm not sure we should bundle it with more changes, but I agree with @lbernick that we must first delete the remaining PipelineResources and then this. |
Changes
This commit cleans up the artifacts package.
It prepares for the removal storage resources to mitigate dependencies.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes