Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update min k8s version in development.md to 1.23 #6366

Closed
wants to merge 1 commit into from
Closed

Update min k8s version in development.md to 1.23 #6366

wants to merge 1 commit into from

Conversation

bobcatfish
Copy link
Collaborator

Changes

As of the 0.41 release the minimum version of k8s required is 1.23

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
jerop
jerop reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobcatfish thanks for the fix! there are three more places where this change needs to be made:

pipeline/docs/resolution-getting-started.md

Line 21 in d89850f

- A Kubernetes cluster running at least Kubernetes 1.22. A [`kind`

pipeline/docs/api-spec.md

Line 45 in d89850f

There is no formal specification of the Kubernetes API and Resource Model. This document assumes Kubernetes 1.22 behavior; this behavior will typically be supported by many future Kubernetes versions. Additionally, this document may reference specific core Kubernetes resources; these references may be illustrative (i.e. an implementation on Kubernetes) or descriptive (i.e. this Kubernetes resource MUST be exposed). References to these core Kubernetes resources will be annotated as either illustrative or descriptive.

pipeline/docs/how-to-write-a-resolver.md

Line 57 in d89850f

- A Kubernetes cluster running at least Kubernetes 1.22. A [`kind`

@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@dibyom
Copy link
Member

dibyom commented Mar 21, 2023

As of the 0.41 release the minimum version of k8s required is 1.23

I think we need to bump to 1.24 given that v0.45 and higher now require K8s 1.24

@dibyom dibyom self-assigned this Mar 22, 2023
lbernick
lbernick reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're actually at 1.24 now: https://github.com/tektoncd/pipeline/blob/main/docs/install.md#prerequisites

edit: I see dibyo already mentioned this 😬

jerop added a commit to jerop/pipeline that referenced this pull request Mar 31, 2023
@jerop @bobcatfish
Update min k8s version to 1.24
ac39a3d 
Prior to this change, the docs indicate that the min k8s version
is 1.22. However, the min k8s version was bumped to 1.23 in v0.41
and bumped to 1.24 in v0.45. This change updates the docs to the
min version of v0.45.

This change also adds a reminder in the pull requests checklist to
update docs of the min requirements if any have changed.

This change supersedes tektoncd#6366
from @bobcatfish.

Co-authored-by: Christie Warwick (Wilson) <[email protected]>
jerop added a commit to jerop/pipeline that referenced this pull request Mar 31, 2023
@jerop @bobcatfish
Update min k8s version to 1.24
dc506d7 
Prior to this change, the docs indicate that the min k8s version
is 1.22. However, the min k8s version was bumped to 1.23 in v0.41
and bumped to 1.24 in v0.45. This change updates the docs to the
min version of v0.45.

This change also adds a reminder in the pull requests checklist to
update docs of the min requirements if any have changed.

This change supersedes tektoncd#6366
from @bobcatfish.

Co-authored-by: Christie Warwick (Wilson) <[email protected]>
@jerop jerop mentioned this pull request Mar 31, 2023
Merged
4 tasks
@jerop
Copy link
Member

jerop commented Mar 31, 2023

@bobcatfish opened #6478 updating the min k8s version in development.md and other files -- and added you as a co-author

/close

@tekton-robot
Copy link
Collaborator

@jerop: Closed this PR.

In response to this:

@bobcatfish opened #6478 updating the min k8s version in development.md and other files -- and added you as a co-author

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop added a commit to jerop/pipeline that referenced this pull request Mar 31, 2023
@jerop @bobcatfish
Update min k8s version to 1.24
7939c0a 
Prior to this change, the docs indicate that the min k8s version
is 1.22. However, the min k8s version was bumped to 1.23 in v0.41
and bumped to 1.24 in v0.45. This change updates the docs to the
min version of v0.45.

This change also adds a reminder in the pull requests checklist to
update docs of the min requirements if any have changed.

This change supersedes tektoncd#6366
from @bobcatfish.

Co-authored-by: Christie Warwick (Wilson) <[email protected]>
tekton-robot pushed a commit that referenced this pull request Apr 3, 2023
@jerop @bobcatfish @tekton-robot
Update min k8s version to 1.24
56cb562 
Prior to this change, the docs indicate that the min k8s version
is 1.22. However, the min k8s version was bumped to 1.23 in v0.41
and bumped to 1.24 in v0.45. This change updates the docs to the
min version of v0.45.

This change also adds a reminder in the pull requests checklist to
update docs of the min requirements if any have changed.

This change supersedes #6366
from @bobcatfish.

Co-authored-by: Christie Warwick (Wilson) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@jerop jerop jerop left review comments

@dibyom dibyom dibyom approved these changes

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bobcatfish @vdemeester @tekton-robot @dibyom @jerop @lbernick