feat: support to produce results from a failed task #6510

pritidesai · 2023-04-07T21:53:07Z

Changes

If the task fails or succeeds, as long as the task result is initialized, it can be successfully parsed and can be referenced by the final task.

This commit enables the failed task to produce the task results, and the final task can reference it.

Closes #5749

This is a duplicate of #5750 but with conflicts resolved and e2e test. I was reviewing PR #5750 and decided to create an e2e test. After noticing it had merge conflicts, decided to resolve them and create this PR. @cugykw is now a co-author of this commit.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

PipelineRun can produce task results from the failed tasks, and the final task can reference those results.

tekton-robot · 2023-04-07T21:58:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

tekton-robot · 2023-04-07T22:00:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

pritidesai · 2023-04-07T22:08:31Z

/kind feature

assigning to the reviewers of original pr:

/assign @vdemeester
/assign @chitrangpatel

tekton-robot · 2023-04-07T22:10:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

tekton-robot · 2023-04-07T22:12:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

tekton-robot · 2023-04-07T23:21:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

tekton-robot · 2023-04-07T23:23:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

pritidesai · 2023-04-08T00:08:19Z

looks like a flake, at least one of them didn't fail earlier:

test: TestTaskResultsFromFailedTasks expand_more | 6s
test: TestPipelineTaskTimeout expand_more

Was able to run TestTaskResultsFromFailedTasks with alpha flag.

pritidesai · 2023-04-08T00:08:27Z

/retest

tekton-robot · 2023-04-11T15:25:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

QuanZhang-William · 2023-04-12T17:50:19Z

/assign

pritidesai · 2023-05-18T17:24:34Z

/retest

pritidesai · 2023-05-18T20:44:54Z

So the alpha test failure is not a flake 😞

But it is interesting that the same test succeeds with stable and beta integration test check.

The logs of tests with stable: https://storage.googleapis.com/tekton-prow/pr-logs/pull/tektoncd_pipeline/6510/pull-tekton-pipeline-integration-tests/1644479150448185344/build-log.txt

The logs of tests with alpha: https://storage.googleapis.com/tekton-prow/pr-logs/pull/tektoncd_pipeline/6510/pull-tekton-pipeline-alpha-integration-tests/1659248641593839616/build-log.txt

The difference is:

With stable only one task is skipped as expected:

Message:            "Tasks Completed: 2 (Failed: 1, Cancelled 0), Skipped: 1",

With alpha, the final task which was expected to execute is skipped with the reason "Results were missing":

Message:            "Tasks Completed: 1 (Failed: 1, Cancelled 0), Skipped: 2",

pritidesai · 2023-05-18T20:48:11Z

hey @chitrangpatel, do you think the configuration of RESULTS_FROM=sidecar-logs could be causing a final task to skip if the dependent task fails?

chitrangpatel · 2023-05-18T21:16:27Z

pkg/pod/status.go

@@ -208,7 +208,7 @@ func setTaskRunStatusBasedOnStepStatus(ctx context.Context, logger *zap.SugaredL
 				}

 				taskResults, filteredResults := filterResults(results, specResults)
-				if tr.IsSuccessful() {
+				if tr.IsDone() {


I think you need to do the same thing in line 185 as well.

That will account for the same change when fetching results from sidecar logs too.

thanks a bunch @chitrangpatel for a quick response 🙏 hopefully works now 🤞

If the task fails or succeeds, as long as the task result is initialized, it can be successfully parsed and can be referenced by the final task. This commit enables the failed task to produce the task results, and the final task can reference it. Please see detailed description in issue tektoncd#5749 Co-authored-by: yang kewei <[email protected]> Signed-off-by: pritidesai <[email protected]> Signed-off-by: Priti Desai <[email protected]>

tekton-robot · 2023-05-18T21:27:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

tekton-robot · 2023-05-18T21:31:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pod/status.go	91.2%	91.6%	0.4

chitrangpatel · 2023-05-18T22:31:39Z

/lgtm

chitrangpatel · 2023-05-19T00:03:40Z

/retest

pritidesai · 2023-05-19T03:59:09Z

/test pull-tekton-pipeline-go-coverage-df

tekton-robot · 2023-05-19T03:59:10Z

@pritidesai: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pritidesai · 2023-05-19T04:00:29Z

/retest

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 7, 2023

tekton-robot requested review from dibyom and imjasonh April 7, 2023 21:53

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2023

pritidesai force-pushed the extract-failed-task-result branch from 5ab2bb7 to 5270e26 Compare April 7, 2023 22:05

pritidesai mentioned this pull request Apr 7, 2023

feat:support to extract failed task results #5750

Closed

7 tasks

tekton-robot assigned chitrangpatel Apr 7, 2023

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 7, 2023

tekton-robot assigned vdemeester Apr 7, 2023

pritidesai force-pushed the extract-failed-task-result branch from 5270e26 to afc4db7 Compare April 7, 2023 23:15

vdemeester approved these changes Apr 11, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023

tekton-robot assigned QuanZhang-William Apr 12, 2023

pritidesai mentioned this pull request May 18, 2023

don't return validation error when taskrun failed/skipped #6395

Merged

7 tasks

chitrangpatel reviewed May 18, 2023

View reviewed changes

pritidesai force-pushed the extract-failed-task-result branch from afc4db7 to 660e742 Compare May 18, 2023 21:21

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023

tekton-robot merged commit 2eadca5 into tektoncd:main May 19, 2023

pritidesai deleted the extract-failed-task-result branch May 23, 2023 15:55

pritidesai mentioned this pull request Jun 29, 2023

Finally tasks should be triggered in case of missing results #4438

Closed

EmmaMunley mentioned this pull request Aug 7, 2023

[TEP-0140] Produce Results from Matrixed PipelineTasks tektoncd/community#1047

Merged

This was referenced Sep 11, 2023

Publish results when task and pipeline runs fail #3749

Open

Upgrade Tekton Pipeline to v0.51.0 enterprise-contract/ec-cli#1001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support to produce results from a failed task #6510

feat: support to produce results from a failed task #6510

pritidesai commented Apr 7, 2023 •

edited

Loading

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

pritidesai commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

pritidesai commented Apr 8, 2023

pritidesai commented Apr 8, 2023

tekton-robot commented Apr 11, 2023

QuanZhang-William commented Apr 12, 2023

pritidesai commented May 18, 2023

pritidesai commented May 18, 2023

pritidesai commented May 18, 2023

chitrangpatel May 18, 2023

chitrangpatel May 18, 2023

pritidesai May 18, 2023

tekton-robot commented May 18, 2023

tekton-robot commented May 18, 2023

chitrangpatel commented May 18, 2023

chitrangpatel commented May 19, 2023

pritidesai commented May 19, 2023

tekton-robot commented May 19, 2023

pritidesai commented May 19, 2023

feat: support to produce results from a failed task #6510

feat: support to produce results from a failed task #6510

Conversation

pritidesai commented Apr 7, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

pritidesai commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

tekton-robot commented Apr 7, 2023

pritidesai commented Apr 8, 2023

pritidesai commented Apr 8, 2023

tekton-robot commented Apr 11, 2023

QuanZhang-William commented Apr 12, 2023

pritidesai commented May 18, 2023

pritidesai commented May 18, 2023

pritidesai commented May 18, 2023

chitrangpatel May 18, 2023

Choose a reason for hiding this comment

chitrangpatel May 18, 2023

Choose a reason for hiding this comment

pritidesai May 18, 2023

Choose a reason for hiding this comment

tekton-robot commented May 18, 2023

tekton-robot commented May 18, 2023

chitrangpatel commented May 18, 2023

chitrangpatel commented May 19, 2023

pritidesai commented May 19, 2023

tekton-robot commented May 19, 2023

pritidesai commented May 19, 2023

pritidesai commented Apr 7, 2023 •

edited

Loading