6483-Step1: move validation code out of pipeline_types.go #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the step 1 of tektoncd#6483, this commit moves validation function from pipeline_types.go to pipeline_validation.go No impact on the downstream consumers b/c they stay in the same package. Signed-off-by: Chuang Wang <[email protected]>
tekton-robot
added
kind/cleanup
tekton-robot
added
the
size/XXL
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
dibyom
approved these changes
Apr 13, 2023
tekton-robot
added
the
approved
|
/lgtm |
|
/retest |
vdemeester
approved these changes
Apr 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v0.44.x
sorry wrong paste while loading under vpn connection |
|
@JeromeJu: #6526 failed to apply on top of branch "release-v0.44.x": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind cleanup
As part of the step 1 of #6483, this commit moves validation functions from pipeline_types.go to pipeline_validation.go
No impact on the downstream consumers b/c they stay in the same package.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes