Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-architecture build of e2e and plumbing images #592

Closed
vdemeester opened this issue Sep 24, 2020 · 9 comments
Closed

Multi-architecture build of e2e and plumbing images #592

vdemeester opened this issue Sep 24, 2020 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@vdemeester
Copy link
Member

In order to support multiple architecture, we need to provide image in multiple
architecture for the projects's end-to-end tests. This also applies to some images built
in plumbing as we may use them on the target clusters (s390x, arm64, …) and/or during
end-to-end tests.

In an ideal world, we would use tekton to build those (aka dogfooding, …). My initial
search around this mainly ended up around qemu, qemu-user-static and docker (+buildkit).

See

So the questions is how should we proceed:

  • Have a quick way of building multi-arch images using github action (as above)
  • Have a "middle" solution where we use dogfooding with some DinD, privileged containers
    and buildx
  • Find some way to replicate the github action flow in tekton (ideally without any need to
    privileged containers, but I have high doubt that it's possible)

/cc @afrittoli
/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2020
@barthy1
Copy link
Member

barthy1 commented Sep 29, 2020

Can first versions of the mentioned images be built using the fastest way? I guess it would be github actions. Just to unblock "other arch support" activities..
And some longer but more conceptual approach can be used after.

@vdemeester
Copy link
Member Author

@barthy1 yeah, @afrittoli said the same during our productivity working group 👼

@barthy1
Copy link
Member

barthy1 commented Oct 2, 2020

@vdemeester I'd like to suggest the first candidate for multi-arch build here is gcr.io/tekton-nightly/github.com/tektoncd/pipeline/build-base:latest, as it's used in .ko.yaml for pipeline, and required to be mluti-arch to use --platform=all option. At this moment it is built by gcr.io/kaniko-project/executor:v0.17.1, which doesn't support multi-arch manifest.
Do you think it makes sense to have the workflow to run Github actions build in plumbing or better in pipeline?

@barthy1
Copy link
Member

barthy1 commented Oct 2, 2020

One more idea, for future extensions. We can use Tekton task to start Github action - https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_dispatch :)

@chmouel
Copy link
Member

chmouel commented Oct 8, 2020

Is there any cloud provider we could have access to ? (IBM, Google or others), where we can just spin up a VM there, inject our build script from a tekton task and get back the multi arch build ?

I understand that Github may seem easy to implement but I think we have the opportunity to show that tekton can be the right CI tool for this kind of workflow and not having to leverage another CI provider for it.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2021
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2021
@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants