Switch Pipeline to Kind-in-Prow e2e jobs #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a bit simpler to delete the old ones and rename the new ones. This also removes the separate YAML-only kind jobs, since the "combined" jobs are fast enough. Additionally, this sets the CPU requests/limits for the Pipeline build tests job to 8000m, since it's extremely CPU dependent, and this should drop its run time considerably from the 40+ minutes it often is now. We've easily got the capacity for that increased requirement with the e2e jobs moving to separate n2-standard-4s. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
the
kind/misc
|
/hold Holding until tektoncd/pipeline#5077 is done and merged. |
tekton-robot
added
size/L
5 tasks
|
/assign @dibyom @afrittoli @vdemeester |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
/lgtm |
afrittoli
reviewed
Jul 14, 2022
Comment on lines
+1158
to
+1161
| cpu: 8000m | ||
| memory: 4Gi | ||
| limits: | ||
| cpu: 4000m | ||
| cpu: 8000m |
| @@ -1295,25 +1224,24 @@ presubmits: | |||
| limits: | |||
| cpu: 4000m | |||
| memory: 8Gi | |||
| - name: pull-tekton-pipeline-kind-integration-tests | |||
| - name: pull-tekton-pipeline-integration-tests | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It was a bit simpler to delete the old ones and rename the new ones. This also removes the separate YAML-only kind jobs, since the "combined" jobs are fast enough.
Additionally, this sets the CPU requests/limits for the Pipeline build tests job to 8000m, since it's extremely CPU dependent, and this should drop its run time considerably from the 40+ minutes it often is now. We've easily got the capacity for that increased requirement with the e2e jobs moving to separate n2-standard-4s.
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.