-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prow test-runner. #1369
Bump prow test-runner. #1369
Conversation
Primarily to upgrade to Go 1.19. NOTE: This may cause some test failures due to changes in gofmt. Repos just need to re-run codegen w/ Go 1.19+ once this is live.
/cc @vdemeester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Billy:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Primarily to upgrade to Go 1.19.
$ docker run --entrypoint bash -it gcr.io/tekton-releases/dogfooding/test-runner@sha256:9b8548ad06ebb2acc420aa588d47637bd37e9f563588f47c43b22560dc1ce3f8 root@1c25d7f1b443:/# go version go version go1.19 linux/amd64
NOTE: This may cause some test failures due to changes in gofmt. Repos just need to re-run codegen w/ Go 1.19+ once this is live.
Fixes tektoncd/pipeline#5771
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.