Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file causing Pipelines nightly deploy to fail #1819

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

AlanGreene
Copy link
Member

Changes

Robocat is stuck on Pipelines v20230307-771fb665f2 due to an error in the nightly deploy TaskRun, see for example
https://dashboard.dogfooding.tekton.dev/#/namespaces/default/pipelineruns/deploy-pipeline-release-robocat-4wdnt?pipelineTask=install-tekton-release&step=deploy-tekton-project

2024-02-15T03:01:00.091452354Z + kubectl apply --kubeconfig /workspace/targetCluster/kubeconfig -k pipeline/overlays/robocat
2024-02-15T03:01:02.736006696Z error: no matches for Id ~G_v1_ConfigMap|tekton-pipelines|config-artifact-bucket; failed to find unique target for patch ~G_v1_ConfigMap|config-artifact-bucket

The referenced ConfigMap was removed from Pipelines in tektoncd/pipeline#6150 which was merged on March 7th.

Remove the file from the overlay as it's no longer used.

/kind misc

/cc @JeromeJu @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Robocat is stuck on Pipelines `v20230307-771fb665f2` due to an error
in the nightly deploy TaskRun.

See for example from the most recent run:
```
2024-02-15T03:01:00.091452354Z + kubectl apply --kubeconfig /workspace/targetCluster/kubeconfig -k pipeline/overlays/robocat
2024-02-15T03:01:02.736006696Z error: no matches for Id ~G_v1_ConfigMap|tekton-pipelines|config-artifact-bucket; failed to find unique target for patch ~G_v1_ConfigMap|config-artifact-bucket
```

The referenced ConfigMap was removed from Pipelines in tektoncd/pipeline#6150 which was merged on March 7th.

Remove the file from the overlay as it's no longer used.
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 15, 2024
@tekton-robot
Copy link
Contributor

@AlanGreene: GitHub didn't allow me to request PR reviews from the following users: JeromeJu.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

Robocat is stuck on Pipelines v20230307-771fb665f2 due to an error in the nightly deploy TaskRun, see for example
https://dashboard.dogfooding.tekton.dev/#/namespaces/default/pipelineruns/deploy-pipeline-release-robocat-4wdnt?pipelineTask=install-tekton-release&step=deploy-tekton-project

2024-02-15T03:01:00.091452354Z + kubectl apply --kubeconfig /workspace/targetCluster/kubeconfig -k pipeline/overlays/robocat
2024-02-15T03:01:02.736006696Z error: no matches for Id ~G_v1_ConfigMap|tekton-pipelines|config-artifact-bucket; failed to find unique target for patch ~G_v1_ConfigMap|config-artifact-bucket

The referenced ConfigMap was removed from Pipelines in tektoncd/pipeline#6150 which was merged on March 7th.

Remove the file from the overlay as it's no longer used.

/kind misc

/cc @JeromeJu @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
@tekton-robot
Copy link
Contributor

tekton-robot commented Feb 15, 2024

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label 203af5d link true /test check-pr-has-kind-label

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlanGreene
/lgtm

@tekton-robot
Copy link
Contributor

@JeromeJu: changing LGTM is restricted to collaborators

In response to this:

Thanks @AlanGreene
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene AlanGreene changed the title Remove unused file from Pipelines nightly deploy Remove unused causing Pipelines nightly deploy to fail Feb 16, 2024
@AlanGreene AlanGreene changed the title Remove unused causing Pipelines nightly deploy to fail Remove unused file causing Pipelines nightly deploy to fail Feb 16, 2024
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2024
@tekton-robot tekton-robot merged commit 7ebf082 into tektoncd:main Feb 18, 2024
3 of 4 checks passed
@AlanGreene AlanGreene deleted the pipeline_nightly_deploy branch February 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants