Don't use go modules for licenseclassifier. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XS
|
/kind bug |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/test plumbing-golang-lint |
I think this is causing the current presubmit error: Error: cannot register licenses from archive: open /home/prow/go/pkg/mod/github.com/google/[email protected]/licenses/licenses.db: no such file or directory This was changed to use modules in tektoncd@fb80e6b Signed-off-by: Vincent Demeester <[email protected]>
|
/lgtm |
This was referenced Jul 20, 2020
dlorenc
added a commit
to dlorenc/plumbing
that referenced
this pull request
Jul 20, 2020
go-licenses save is still failing in CI across our repos. I missed this in tektoncd#485 I'm still mostly just guessing at fixes because I don't have a great way to repro this locally.
1 task
tekton-robot
pushed a commit
that referenced
this pull request
Jul 20, 2020
go-licenses save is still failing in CI across our repos. I missed this in #485 I'm still mostly just guessing at fixes because I don't have a great way to repro this locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I think this is causing the current presubmit error:
Error: cannot register licenses from archive: open /home/prow/go/pkg/mod/github.com/google/[email protected]/licenses/licenses.db: no such file or directory
This was changed to use modules in fb80e6b
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.