-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pipeline to deploy and test a release of a Tekton project #73
Conversation
Add a Task that gets a release of a Tekton project from the release bucket, and installs it in a target cluster.
/hold |
Added "hold" to allow for a couple of reviews. This is not used anywhere yet but I'm building a pipeline to test releases bit by bit. |
Add a task to verify the release YAML from the bucket against that stored in the GitHub release assets. Add a pipeline that runs the verify and the deploy tasks, and that eventually will also run the E2E tests.
Related to #75 |
Add a step to the deploy task that verifies that all pods in the target namespace are running normally. This uses functions from plumbing/scripts.sh.
Similar to what is done today in CI logs, add a task to log the versions of tools in the test-runner. This is helpful for debugging failures.
b0087b1
to
bbc341b
Compare
The task uses functions from the library.sh to run the e2e tests. Update the pipeline and docs to run the tests.
bbc341b
to
571c38e
Compare
ebc528f
to
b9ff276
Compare
5f261af
to
0635667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good (I need to dig deeper though 👼 )
@@ -0,0 +1,48 @@ | |||
# How to follow log outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we just point to tkn
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is copied straight from pipeline - we might do something different eventually - but I wanted to have a smooth migration, by using the existing scripts mostly wrapped into tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 👼
(I was about to remove that piece of code from pipeline
😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen your PR about this, once it's done on pipelines I can port it to plumbing if that's ok.
0635667
to
ed1a1f3
Compare
ed1a1f3
to
797bfd7
Compare
/hold cancel |
I think this is in a reasonable state to go into the repo now, and then iterate from here. |
YAML tests are executed in pipeline, but they may also be useful for catalog and triggers for instance. Copying some common functions from pipeline to library.sh in plumbing, adding a Task to run the yaml tests and adding the YAML tests task to the release test pipeline.
797bfd7
to
7711941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a Task that gets a release of a Tekton project from the release
bucket, and installs it in a target cluster.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.