Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pipeline to deploy and test a release of a Tekton project #73

Merged
merged 6 commits into from
Oct 16, 2019

Conversation

afrittoli
Copy link
Member

Add a Task that gets a release of a Tekton project from the release
bucket, and installs it in a target cluster.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Add a Task that gets a release of a Tekton project from the release
bucket, and installs it in a target cluster.
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2019
@afrittoli
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@afrittoli
Copy link
Member Author

Added "hold" to allow for a couple of reviews. This is not used anywhere yet but I'm building a pipeline to test releases bit by bit.

@vdemeester vdemeester self-requested a review September 24, 2019 15:41
Add a task to verify the release YAML from the bucket against that
stored in the GitHub release assets.
Add a pipeline that runs the verify and the deploy tasks, and that
eventually will also run the E2E tests.
@afrittoli
Copy link
Member Author

Related to #75

Add a step to the deploy task that verifies that all pods in the
target namespace are running normally.

This uses functions from plumbing/scripts.sh.
Similar to what is done today in CI logs, add a task to log the
versions of tools in the test-runner. This is helpful for
debugging failures.
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2019
@afrittoli afrittoli force-pushed the dogfooding_folder branch 2 times, most recently from b0087b1 to bbc341b Compare October 1, 2019 13:42
The task uses functions from the library.sh to run the e2e tests.
Update the pipeline and docs to run the tests.
@afrittoli afrittoli changed the title Add a Task to install a released Tekton project Add a pipeline to deploy and test a release of a Tekton project Oct 1, 2019
@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2019
@afrittoli afrittoli force-pushed the dogfooding_folder branch 3 times, most recently from ebc528f to b9ff276 Compare October 7, 2019 19:33
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 7, 2019
@afrittoli afrittoli force-pushed the dogfooding_folder branch 2 times, most recently from 5f261af to 0635667 Compare October 7, 2019 21:14
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good (I need to dig deeper though 👼 )

@@ -0,0 +1,48 @@
# How to follow log outputs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just point to tkn instead ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copied straight from pipeline - we might do something different eventually - but I wanted to have a smooth migration, by using the existing scripts mostly wrapped into tasks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👼
(I was about to remove that piece of code from pipeline 😅)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen your PR about this, once it's done on pipelines I can port it to plumbing if that's ok.

tekton/README Outdated Show resolved Hide resolved
@afrittoli
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
@afrittoli
Copy link
Member Author

I think this is in a reasonable state to go into the repo now, and then iterate from here.

@afrittoli afrittoli added this to the Pipelines 0.8 🐱 milestone Oct 14, 2019
YAML tests are executed in pipeline, but they may also be useful
for catalog and triggers for instance. Copying some common
functions from pipeline to library.sh in plumbing, adding a Task
to run the yaml tests and adding the YAML tests task to the
release test pipeline.
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@tekton-robot tekton-robot merged commit def94fe into tektoncd:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants