Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.12.x] Fix Panic in the API server #872

Conversation

tekton-robot
Copy link

This is an automated cherry-pick of #870

/assign khrm

Your release note here

@tekton-robot tekton-robot mentioned this pull request Nov 4, 2024
8 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 4, 2024
@khrm
Copy link
Contributor

khrm commented Nov 4, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
API server gets panic under certain negative scenarios.
We fixed that by creating a new variable for error.
@tekton-robot tekton-robot force-pushed the cherry-pick-870-to-release-v0.12.x branch from 29b6774 to d49708d Compare November 4, 2024 17:04
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@khrm
Copy link
Contributor

khrm commented Nov 4, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@khrm
Copy link
Contributor

khrm commented Nov 5, 2024

/test pull-tekton-results-unit-tests


@khrm
Copy link
Contributor

khrm commented Nov 5, 2024

/approve

@tekton-robot
Copy link
Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@khrm khrm merged commit c613399 into tektoncd:release-v0.12.x Nov 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants