Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming branches: handling triggers and CLI repository #240

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 3, 2021

Changes

Changing links to any reference to tektoncd/triggers.

Signed-off-by: Vincent Demeester [email protected]

/hold
/cc @afrittoli @bobcatfish @imjasonh

Related to tektoncd/plumbing#681

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2021
Base automatically changed from master to main February 3, 2021 16:10
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@vdemeester
Copy link
Member Author

/cc @afrittoli @AlanGreene

@tekton-robot tekton-robot requested a review from AlanGreene March 10, 2021 15:16
@AlanGreene
Copy link
Member

same as the CLI one, it'll need a new commit pushed to trigger the netlify build
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
Changing links to any reference to tektoncd/cli.

Signed-off-by: Vincent Demeester <[email protected]>
@afrittoli
Copy link
Member

same as the CLI one, it'll need a new commit pushed to trigger the netlify build
/approve

I can trigger it manually from netlify

@afrittoli
Copy link
Member

This one fails because of CLI and the CLI one fails because of this.
You'll need to merge the two PRs into one for it to work.
@vdemeester

Changing links to any reference to tektoncd/triggers.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2021
@afrittoli afrittoli changed the title Renaming branches: handling triggers repository Renaming branches: handling triggers and CLI repository Mar 10, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@tekton-robot tekton-robot merged commit bb25ab3 into tektoncd:main Mar 10, 2021
@vdemeester vdemeester deleted the main-triggers branch March 10, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants