-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mermaid to fix Results data model diagram #588
Conversation
/cc @afrittoli @geriom |
Instead of just updating the mermaid, we should bump the docsy version. This will bring more features and fixes along with the mermaid fix. It was updated a long time ago, given the website uses docsy 0.6 and the latest is 0.8 (https://github.com/google/docsy/releases/tag/v0.8.0) |
@avinal I agree that we should update docsy however I don't currently have time to work on this, especially given the warning about significant breaking changes in 0.7. If someone else has time to work on this in the near future that would be great. In the meantime this is a small targetted fix to resolve a current issue on the website affecting our users. |
Yes, Docsy is now running on a newer version of bootstrap. I might have some time to look into this in late April, if someone wants to take a look sooner, I can share some useful links to help with the migration process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avinal, geriom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Related tektoncd/results#708
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.