Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mermaid to fix Results data model diagram #588

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Feb 8, 2024

Changes

Related tektoncd/results#708
/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 8, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@AlanGreene
Copy link
Member Author

/cc @afrittoli @geriom

@avinal
Copy link
Member

avinal commented Feb 12, 2024

Instead of just updating the mermaid, we should bump the docsy version. This will bring more features and fixes along with the mermaid fix. It was updated a long time ago, given the website uses docsy 0.6 and the latest is 0.8 (https://github.com/google/docsy/releases/tag/v0.8.0)

@AlanGreene
Copy link
Member Author

@avinal I agree that we should update docsy however I don't currently have time to work on this, especially given the warning about significant breaking changes in 0.7. If someone else has time to work on this in the near future that would be great.

In the meantime this is a small targetted fix to resolve a current issue on the website affecting our users.

@geriom
Copy link
Contributor

geriom commented Feb 12, 2024

given the warning about significant breaking changes in 0.7. If someone else has time to work on this in the near future that would be great.

Yes, Docsy is now running on a newer version of bootstrap. I might have some time to look into this in late April, if someone wants to take a look sooner, I can share some useful links to help with the migration process.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, geriom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geriom
Copy link
Contributor

geriom commented Feb 13, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@tekton-robot tekton-robot merged commit 7a57496 into tektoncd:main Feb 13, 2024
6 checks passed
@AlanGreene AlanGreene deleted the mermaid branch February 14, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants