Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beefed up the tests #13

Merged
merged 5 commits into from
Oct 2, 2019
Merged

beefed up the tests #13

merged 5 commits into from
Oct 2, 2019

Conversation

CalliEve
Copy link
Contributor

@CalliEve CalliEve commented Oct 2, 2019

this should resolve issue #9. If there are any issues or things that should be improved, please let me know

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ZNielsen
ZNielsen reviewed Oct 2, 2019
View reviewed changes
Copy link
Collaborator

@ZNielsen ZNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question on a possible typo (see review comment)

src/main.rs Outdated Show resolved Hide resolved
@ZNielsen ZNielsen merged commit 9d6099e into tektronix:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZNielsen ZNielsen ZNielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalliEve @CLAassistant @ZNielsen