Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Podman-Docker compatibility layer when installing #1601

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

mattroot
Copy link
Contributor

This might be problematic on RHEL-based systems due to Podman being pushed by Red Hat.
From what I know, it only affects Fedora, Alma and Rocky.

Also, a quick trailing space fix.

BTW: T-Pot does not run on this compatibility layer, at least it didn't back on 22.04.

Copy link
Member

@t3chn0m4g3 t3chn0m4g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Given podman-docker is having podman as a dependency it would make sense to include podman as well:

package: podman-docker-5:5.0.0-1.fc40.noarch
  dependency: /usr/bin/sh
   provider: bash-5.2.26-3.fc40.aarch64
  dependency: podman = 5:5.0.0-1.fc40
   provider: podman-5:5.0.0-1.fc40.aarch64

package: podman-docker-5:5.1.1-1.fc40.noarch
  dependency: /usr/bin/sh
   provider: bash-5.2.26-3.fc40.aarch64
  dependency: podman = 5:5.1.1-1.fc40
   provider: podman-5:5.1.1-1.fc40.aarch64

@mattroot
Copy link
Contributor Author

mattroot commented Jul 2, 2024

Podman itself does not get in the way, it's just the compatibility layer. Although we can remove it, if we intend to hold just T-Pot on a said machine (which makes sense)

@mattroot mattroot requested a review from t3chn0m4g3 July 2, 2024 23:03
@t3chn0m4g3 t3chn0m4g3 added this to the 24.04.1 milestone Jul 3, 2024
Copy link
Member

@t3chn0m4g3 t3chn0m4g3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t3chn0m4g3 t3chn0m4g3 merged commit f41c15e into telekom-security:master Jul 11, 2024
@t3chn0m4g3
Copy link
Member

Thanks for playing 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants