feat/target-manager-registered-metric #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #231
A metric in the target manager component should expose the current state of the sparrow (whether it's registered or not.)
Changes
Tests done
Manual E2E tests were done. The sparrow exposes the new metric and it's 0 on start and is set to 1 upon registration.
Deregistration wasn't tested in an e2e setting, as deregistration only happens upon shutdown -> the metric isn't exposed anymore. I didn't start a local prometheus just to check whether the last state would've parsed. Additionally, as there is no guarantee that the last state of the metric will be parsed from prometheus, I don't know how one can easily test this scenario without some complicated setup :)
TODO