Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(threat): add Verify datasets function #165

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

dwisiswant0
Copy link
Collaborator

IMPORTANT: Please do not create a PR without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

feat(threat): add Verify datasets function

Proposed of changes

This PR fixes/implements the following bugs/features:

How has this been tested?

Proof:

Closing issues

Fixes #

Checklist:

  • My code follows the code style of this project.
  • My changes successfully ran and pass linters locally (run make lint).
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ctrlcctrlv Fredrick Brennan
Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0 dwisiswant0 force-pushed the dwisiswant0/feat/checksum-threat-datasets branch from e635d7d to a3fa96d Compare February 25, 2024 14:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 78.42%. Comparing base (b2aee2a) to head (a3fa96d).
Report is 1 commits behind head on master.

Files Patch % Lines
threat/verify.go 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   81.45%   78.42%   -3.03%     
==========================================
  Files          15       16       +1     
  Lines         906      941      +35     
==========================================
  Hits          738      738              
- Misses        110      145      +35     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0 dwisiswant0 merged commit 99e86bb into master Feb 26, 2024
14 checks passed
@dwisiswant0 dwisiswant0 deleted the dwisiswant0/feat/checksum-threat-datasets branch February 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants