fix(html): remove k-header class from tabstrip

The k-header class does not add any styles and seems to be obsolete
telerik · Dec 2, 2024 · 9642807 · 9642807
1 parent 40d95f3
commit 9642807
Show file tree

Hide file tree

Showing 13 changed files with 21 additions and 26 deletions.
diff --git a/packages/html/src/column-menu/templates/column-menu-tabbed.tsx b/packages/html/src/column-menu/templates/column-menu-tabbed.tsx
@@ -5,7 +5,7 @@ export const ColumnMenuTabbed = (props) => (
     <ColumnMenu
         view="tabbed"
         children={
-            <TabStripNormal header={false} className="k-pos-relative"
+            <TabStripNormal className="k-pos-relative"
                 tabStripItems={
                     <>
                         <TabStripItem active icon="filter" />

diff --git a/packages/html/src/column-menu/tests/column-menu-tabbed.tsx b/packages/html/src/column-menu/tests/column-menu-tabbed.tsx
@@ -26,7 +26,7 @@ export default () =>(
 
             <section>
                 <ColumnMenuTabbed>
-                    <TabStripNormal header={false} className="k-overflow-hidden"
+                    <TabStripNormal className="k-overflow-hidden"
                         tabStripItems={
                             <>
                                 <TabStripItem icon="filter" />
@@ -56,7 +56,7 @@ export default () =>(
 
             <section>
                 <ColumnMenuTabbed>
-                    <TabStripNormal header={false} className="k-overflow-hidden"
+                    <TabStripNormal className="k-overflow-hidden"
                         tabStripItems={
                             <>
                                 <TabStripItem active icon="filter" />
@@ -73,7 +73,7 @@ export default () =>(
 
             <section>
                 <ColumnMenuTabbed>
-                    <TabStripNormal header={false} className="k-pos-relative"
+                    <TabStripNormal className="k-pos-relative"
                         tabStripItems={
                             <>
                                 <TabStripItem active icon="filter" />

diff --git a/packages/html/src/editor/tests/editor-find-replace.tsx b/packages/html/src/editor/tests/editor-find-replace.tsx
@@ -36,7 +36,7 @@ export default () =>(
 
             <section>
                 <WindowNormal title="Find and Replace" actions={[ 'x' ]}>
-                    <TabStripNormal header={false} className="k-editor-find-replace"
+                    <TabStripNormal className="k-editor-find-replace"
                         tabStripItems={
                             <>
                                 <TabStripItem className="k-tab-on-top" value="Find" active />
@@ -76,7 +76,7 @@ export default () =>(
 
             <section>
                 <WindowNormal className="k-editor-window" title="Find and Replace" actions={[ 'x' ]}>
-                    <TabStripNormal header={false} className="k-editor-find-replace"
+                    <TabStripNormal className="k-editor-find-replace"
                         tabStripItems={
                             <>
                                 <TabStripItem value="Find" />

diff --git a/packages/html/src/editor/tests/editor-table-wizard.tsx b/packages/html/src/editor/tests/editor-table-wizard.tsx
@@ -37,7 +37,7 @@ export default () =>(
                         <Button>Cancel</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first active value="General"/>
@@ -138,7 +138,7 @@ export default () =>(
                         <Button>Cancel</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="General"/>

diff --git a/packages/html/src/gantt/tests/gantt-editing-popup-general.tsx b/packages/html/src/gantt/tests/gantt-editing-popup-general.tsx
@@ -29,7 +29,7 @@ export default () =>(
                         <Button icon="trash" fillMode="flat" themeColor="primary">Delete</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first active value="General" />

diff --git a/packages/html/src/gantt/tests/gantt-editing-popup-other.tsx b/packages/html/src/gantt/tests/gantt-editing-popup-other.tsx
@@ -30,7 +30,7 @@ export default () =>(
                         <Button icon="trash" fillMode="flat" themeColor="primary">Delete</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="General" />

diff --git a/packages/html/src/gantt/tests/gantt-editing-popup-predecessors.tsx b/packages/html/src/gantt/tests/gantt-editing-popup-predecessors.tsx
@@ -28,7 +28,7 @@ export default () =>(
                         <Button icon="trash" fillMode="flat" themeColor="primary">Delete</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="General" />

diff --git a/packages/html/src/gantt/tests/gantt-editing-popup-resources.tsx b/packages/html/src/gantt/tests/gantt-editing-popup-resources.tsx
@@ -28,7 +28,7 @@ export default () =>(
                         <Button icon="trash" fillMode="flat" themeColor="primary">Delete</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="General" />

diff --git a/packages/html/src/gantt/tests/gantt-editing-popup-successors.tsx b/packages/html/src/gantt/tests/gantt-editing-popup-successors.tsx
@@ -27,7 +27,7 @@ export default () =>(
                         <Button icon="trash" fillMode="flat" themeColor="primary">Delete</Button>
                     </>
                 }>
-                    <TabStripNormal header={false}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="General" />

diff --git a/packages/html/src/grid/tests/grid-column-menu-tabbed.tsx b/packages/html/src/grid/tests/grid-column-menu-tabbed.tsx
@@ -29,7 +29,7 @@ export default () =>(
             <section>
                 <Popup className="k-grid-columnmenu-popup">
                     <ColumnMenuTabbed>
-                        <TabStripNormal header={false} className="k-overflow-hidden"
+                        <TabStripNormal className="k-overflow-hidden"
                             tabStripItems={
                                 <>
                                     <TabStripItem active icon="filter" />
@@ -49,7 +49,7 @@ export default () =>(
             <section>
                 <Popup className="k-grid-columnmenu-popup">
                     <ColumnMenuTabbed>
-                        <TabStripNormal header={false} className="k-overflow-hidden"
+                        <TabStripNormal className="k-overflow-hidden"
                             tabStripItems={
                                 <>
                                     <TabStripItem icon="filter" />
@@ -82,7 +82,7 @@ export default () =>(
             <section>
                 <Popup className="k-grid-columnmenu-popup">
                     <ColumnMenuTabbed>
-                        <TabStripNormal header={false} className="k-overflow-hidden"
+                        <TabStripNormal className="k-overflow-hidden"
                             tabStripItems={
                                 <>
                                     <TabStripItem icon="filter" />
@@ -129,7 +129,7 @@ export default () =>(
             <section>
                 <Popup className="k-grid-columnmenu-popup">
                     <ColumnMenuTabbed>
-                        <TabStripNormal header={false} className="k-overflow-hidden"
+                        <TabStripNormal className="k-overflow-hidden"
                             tabStripItems={
                                 <>
                                     <TabStripItem active icon="filter" />
@@ -148,7 +148,7 @@ export default () =>(
             <section>
                 <Popup className="k-grid-columnmenu-popup">
                     <ColumnMenuTabbed>
-                        <TabStripNormal header={false} className="k-pos-relative"
+                        <TabStripNormal className="k-pos-relative"
                             tabStripItems={
                                 <>
                                     <TabStripItem active icon="filter" />

diff --git a/packages/html/src/spreadsheet/spreadsheet-sheets-bar.tsx b/packages/html/src/spreadsheet/spreadsheet-sheets-bar.tsx
@@ -61,8 +61,7 @@ export const SpreadsheetSheetsBar = (
                 tabStripItems={tabStripItems}
                 position="bottom"
                 scrollable
-                scrollButtonsPosition="end"
-                header={false} />
+                scrollButtonsPosition="end" />
         </div>
     );
 };

diff --git a/packages/html/src/spreadsheet/tests/spreadsheet-print.tsx b/packages/html/src/spreadsheet/tests/spreadsheet-print.tsx
@@ -26,7 +26,7 @@ export default () =>(
                         <Button themeColor="primary">Save</Button>
                     </>
                 }>
-                    <TabStripNormal header={null}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first active value="Print" />
@@ -138,7 +138,7 @@ export default () =>(
                         <Button themeColor="primary">Save</Button>
                     </>
                 }>
-                    <TabStripNormal header={null}
+                    <TabStripNormal
                         tabStripItems={
                             <>
                                 <TabStripItem first value="Print" />

diff --git a/packages/html/src/tabstrip/tabstrip.spec.tsx b/packages/html/src/tabstrip/tabstrip.spec.tsx
@@ -13,15 +13,13 @@ export type KendoTabStripProps = {
     tabStripItems?: React.JSX.Element | React.JSX.Element[];
     scrollable?: boolean;
     scrollButtonsPosition?: "around" | "start" | "end";
-    header?: boolean | null;
     dir?: "rtl" | "ltr";
 };
 
 const defaultOptions = {
     position: "top",
     tabAlignment: "start",
     scrollButtonsPosition: "around",
-    header: true
 };
 
 export const TabStrip = (
@@ -35,7 +33,6 @@ export const TabStrip = (
         position = defaultOptions.position,
         tabAlignment = defaultOptions.tabAlignment,
         scrollButtonsPosition = defaultOptions.scrollButtonsPosition,
-        header = defaultOptions.header,
         dir,
         ...other
     } = props;
@@ -72,7 +69,6 @@ export const TabStrip = (
                 {
                     [`${TABSTRIP_CLASSNAME}-${position}`]: position,
                     [`${TABSTRIP_CLASSNAME}-scrollable`]: scrollable,
-                    ["k-header"]: header,
                 },
             )}>
             {position === "bottom" && children}