generated from telia-oss/terraform-module-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodejs upgrade #32
Merged
Merged
Nodejs upgrade #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladaGithub
force-pushed
the
nodejs-upgrade
branch
from
April 30, 2024 13:11
a52879f
to
4a8a6ef
Compare
As we discussed, lets think in a future if there is a possibility of excluding .node_modules e.g using layers or Docker based function or only libraries already existing in sdk (if possible). |
neugeeug
previously approved these changes
May 2, 2024
larstobi
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not inspected any files under the node_modules
folder.
vladaGithub
force-pushed
the
nodejs-upgrade
branch
6 times, most recently
from
May 3, 2024 06:49
2106b2a
to
44e4e00
Compare
vladaGithub
force-pushed
the
nodejs-upgrade
branch
from
May 3, 2024 06:51
44e4e00
to
63c5030
Compare
larstobi
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.