Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs upgrade #32

Merged
merged 9 commits into from
May 3, 2024
Merged

Nodejs upgrade #32

merged 9 commits into from
May 3, 2024

Conversation

vladaGithub
Copy link
Contributor

No description provided.

@vladaGithub vladaGithub requested review from nazartm and neugeeug April 30, 2024 13:10
@vladaGithub vladaGithub requested a review from a team as a code owner April 30, 2024 13:10
@neugeeug
Copy link

neugeeug commented May 2, 2024

As we discussed, lets think in a future if there is a possibility of excluding .node_modules e.g using layers or Docker based function or only libraries already existing in sdk (if possible).

neugeeug
neugeeug previously approved these changes May 2, 2024
larstobi
larstobi previously approved these changes May 2, 2024
Copy link
Contributor

@larstobi larstobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not inspected any files under the node_modules folder.

@vladaGithub vladaGithub force-pushed the nodejs-upgrade branch 6 times, most recently from 2106b2a to 44e4e00 Compare May 3, 2024 06:49
@larstobi larstobi merged commit 8229ab4 into master May 3, 2024
2 checks passed
@larstobi larstobi deleted the nodejs-upgrade branch May 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants