Use sqlx without TLS feature #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pgmq extension doesn't use TLS at all - the resulting so library is not linked against libcrypto, i.e. the part of the code using sqlx connect is not used here. The TLS support adds unnecessary dependencies that increases the build time and make building on some platform difficult (due to openssl dependency or lack of rustls/ring support for these platforms). runtime-tokio is a subset of runtime-tokio-native-tls, so if some projects that depend on pgmq-core or pgmq-rs need TLS, they can easily enable runtime-tokio-native-tls on their side.
jirutka
requested review from
ChuckHend,
nhudson,
sjmiller609 and
vrmiguel
as code owners
v0idpwn
approved these changes
Dec 19, 2023
ChuckHend
approved these changes
Dec 19, 2023
vrmiguel
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pgmq extension doesn't use TLS at all - the resulting so library is not linked against libcrypto, i.e. the part of the code using sqlx connect is not used here.
The TLS support adds unnecessary dependencies that increases the build time and make building on some platform difficult (due to openssl dependency or lack of rustls/ring support for these platforms).
runtime-tokio is a subset of runtime-tokio-native-tls, so if some projects that depend on pgmq-core or pgmq-rs need TLS, they can easily enable runtime-tokio-native-tls on their side.