Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove offset casting #40

Merged
merged 9 commits into from
Aug 10, 2023
Merged

remove offset casting #40

merged 9 commits into from
Aug 10, 2023

Conversation

ChuckHend
Copy link
Member

@ChuckHend ChuckHend commented Aug 10, 2023

Fixes potential bug that I think would impact situations where sender's locale is not 'utc', but reader's local is.

create table mytest (id integer, ts timestamp with time zone);

insert into mytest values (2, now())

insert into mytest values (3, now() at time zone 'utc')

select * from mytest

 id |              ts               
----+-------------------------------
  2 | 2023-08-10 13:16:40.646644-05  <- correct (this is right now)
  3 | 2023-08-10 18:16:40.652859-05  <- wrong (this is a point in time in the future)

@ChuckHend ChuckHend marked this pull request as ready for review August 10, 2023 20:43
@ChuckHend ChuckHend changed the title drop offset casting remove offset casting Aug 10, 2023
@ChuckHend ChuckHend merged commit 12c9643 into main Aug 10, 2023
@ChuckHend ChuckHend deleted the fix-inserts branch August 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants