Refactor last bits of old-style build scripting #882

theory · 2025-01-03T23:44:57Z

The exceptions are parquet_s3_fdw and postgresml, which I cannot get to build. The updated extensions are:

clickhouse_fdw
rdkit (which never built before?)

Also simplified the use of cmake in these extensions:

mobilitydb
pgrouting

And upgraded these extensions to:

rdkit 4.6.1
pgrouting 3.7.1

Next, make sure that pljava properly depends on openjdk-11-jdk.

Upgrade the build scripting in tests:

cli/tests/test_builders/Dockerfile.auto_explain
cli/tests/test_builders/Dockerfile.http
cli/tests/test_builders/Dockerfile.pg_stat_statements
cli/tests/test_pljava
cli/tests/test_postgresql_unit
cli/tests/test_postgresql_unit
cli/tests/test_trunk_toml_dirs/pg_cron
cli/tests/test_trunk_toml_dirs/postgis

The pljava test revealed that the pattern adopted in the last month to use make install rather than to mv files broke extensions configured with a directory in their control files, doubling the directory prefix. Update prepare_sharedir_file to notice when files already start with the directory prefix, but keep the old behavior of stripping out extensions for any lingering mv use cases.

Finally, update the README with the cleaner output and add some notes for running tests in Docker Desktop.

aws-amplify-us-east-1 · 2025-01-03T23:47:31Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-882.d2qgksbj4k37j8.amplifyapp.com

The exceptions are `parquet_s3_fdw` and `postgresml`, which I cannot get to build. The updated extensions are: * clickhouse_fdw * rdkit (which never built before?) * cli/tests/test_pljava * cli/tests/test_postgresql_unit * cli/tests/test_trunk_toml_dirs/pg_cron Also simplified the use of `cmake` in these extensions: * mobilitydb * pgrouting And upgraded these extensions to: * rdkit 4.6.1 * pgrouting 3.7.1 Finally, make sure that pljava properly depends on `openjdk-11-jdk`.

The exceptions are `parquet_s3_fdw` and `postgresml`, which I cannot get to build. The updated extensions are: * clickhouse_fdw * rdkit (which never built before?) Also simplified the use of `cmake` in these extensions: * mobilitydb * pgrouting And upgraded these extensions to: * rdkit 4.6.1 * pgrouting 3.7.1 Next, make sure that pljava properly depends on `openjdk-11-jdk`. Upgrade the build scripting in tests: * cli/tests/test_builders/Dockerfile.auto_explain * cli/tests/test_builders/Dockerfile.http * cli/tests/test_builders/Dockerfile.pg_stat_statements * cli/tests/test_pljava * cli/tests/test_postgresql_unit * cli/tests/test_postgresql_unit * cli/tests/test_trunk_toml_dirs/pg_cron * cli/tests/test_trunk_toml_dirs/postgis Finally, update the README with the cleaner output.

The exceptions are `parquet_s3_fdw` and `postgresml`, which I cannot get to build. The updated extensions are: * clickhouse_fdw * rdkit (which never built before?) Also simplified the use of `cmake` in these extensions: * mobilitydb * pgrouting And upgraded these extensions to: * rdkit 4.6.1 * pgrouting 3.7.1 Next, make sure that pljava properly depends on `openjdk-11-jdk`. Upgrade the build scripting in tests: * cli/tests/test_builders/Dockerfile.auto_explain * cli/tests/test_builders/Dockerfile.http * cli/tests/test_builders/Dockerfile.pg_stat_statements * cli/tests/test_pljava * cli/tests/test_postgresql_unit * cli/tests/test_postgresql_unit * cli/tests/test_trunk_toml_dirs/pg_cron * cli/tests/test_trunk_toml_dirs/postgis Finally, update the README with the cleaner output and add some notes for running tests in Docker Desktop.

The exceptions are `parquet_s3_fdw` and `postgresml`, which I cannot get to build. The updated extensions are: * clickhouse_fdw * rdkit (which never built before?) Also simplified the use of `cmake` in these extensions: * mobilitydb * pgrouting And upgraded these extensions to: * rdkit 4.6.1 * pgrouting 3.7.1 Next, make sure that pljava properly depends on `openjdk-11-jdk`. Upgrade the build scripting in tests: * cli/tests/test_builders/Dockerfile.auto_explain * cli/tests/test_builders/Dockerfile.http * cli/tests/test_builders/Dockerfile.pg_stat_statements * cli/tests/test_pljava * cli/tests/test_postgresql_unit * cli/tests/test_postgresql_unit * cli/tests/test_trunk_toml_dirs/pg_cron * cli/tests/test_trunk_toml_dirs/postgis The `pljava` test revealed that the pattern adopted in the last month to use `make install` rather than to `mv` files broke extensions configured with a `directory` in their control files, doubling the directory prefix. Update `prepare_sharedir_file` to notice when files already start with the `directory` prefix, but keep the old behavior of stripping out `extensions` for any lingering `mv` use cases. Finally, update the README with the cleaner output and add some notes for running tests in Docker Desktop.

Also manually set the list of extensions to build. These extensions all have `directory` configurations that need to be rebuilt to benefit from the fix in 76a0694 (#882). Will revert in the next commit.

So as to get the directory fix committed in 76a0694 (#882).

Also manually set the list of extensions to build. These extensions all have `directory` configurations that need to be rebuilt to benefit from the fix in 76a0694 (#882) and deployed in 9a9ef1b (#887). Will revert in the next commit.

So as to get the directory fix committed in 76a0694 (#882).

Also upgrade trunk-test-tembo and manually set the list of extensions to build. These extensions all have `directory` configurations that need to be rebuilt to benefit from the fix in 76a0694 (#882) and deployed in 1d073a4 (#887). Will revert in the next commit.

theory requested review from ianstanton, vrmiguel and ChuckHend as code owners January 3, 2025 23:44

theory force-pushed the final-cleanup branch from b8827e5 to 75d0e6a Compare January 4, 2025 00:10

theory force-pushed the final-cleanup branch from 75d0e6a to 5973d2f Compare January 6, 2025 20:51

theory force-pushed the final-cleanup branch from 5973d2f to 62d7245 Compare January 6, 2025 21:21

theory force-pushed the final-cleanup branch from 62d7245 to c709fd6 Compare January 6, 2025 21:40

theory force-pushed the final-cleanup branch from c709fd6 to d582e42 Compare January 6, 2025 21:50

theory force-pushed the final-cleanup branch from d582e42 to a9e33ae Compare January 6, 2025 22:06

theory force-pushed the final-cleanup branch from a9e33ae to c1f12ba Compare January 6, 2025 23:12

theory force-pushed the final-cleanup branch from c1f12ba to 81373ff Compare January 7, 2025 03:58

theory force-pushed the final-cleanup branch from 81373ff to 9cf2c40 Compare January 7, 2025 13:32

theory force-pushed the final-cleanup branch from 9cf2c40 to 8b3dd1b Compare January 7, 2025 15:16

theory force-pushed the final-cleanup branch from 8b3dd1b to 9b437af Compare January 7, 2025 15:24

theory force-pushed the final-cleanup branch from 9b437af to a1b902d Compare January 7, 2025 17:24

theory force-pushed the final-cleanup branch from a1b902d to b506b9a Compare January 7, 2025 17:47

theory force-pushed the final-cleanup branch from b506b9a to 53d66d3 Compare January 7, 2025 18:00

theory force-pushed the final-cleanup branch from 53d66d3 to 1fed0ae Compare January 8, 2025 02:35

theory force-pushed the final-cleanup branch from 1fed0ae to 76a0694 Compare January 8, 2025 04:29

theory mentioned this pull request Jan 8, 2025

Update READMEs for recent trunk changes #885

Merged

theory added a commit that referenced this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8

eb0b725

So as to get the directory fix committed in 76a0694 (#882).

theory mentioned this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8 #887

Merged

vrmiguel approved these changes Jan 8, 2025

View reviewed changes

theory added a commit that referenced this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8 (887)

3f92a06

So as to get the directory fix committed in 76a0694 (#882).

theory added a commit that referenced this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8 (#887)

9a9ef1b

So as to get the directory fix committed in 76a0694 (#882).

theory merged commit 76a0694 into main Jan 8, 2025
30 checks passed

theory deleted the final-cleanup branch January 8, 2025 16:08

theory added a commit that referenced this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8 (#887)

1d073a4

So as to get the directory fix committed in 76a0694 (#882).

theory added a commit that referenced this pull request Jan 8, 2025

Upgrade Trunk to v0.15.8 (#887)

52c3e4a

So as to get the directory fix committed in 76a0694 (#882).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor last bits of old-style build scripting #882

Refactor last bits of old-style build scripting #882

theory commented Jan 3, 2025 •

edited

Loading

aws-amplify-us-east-1 bot commented Jan 3, 2025

Refactor last bits of old-style build scripting #882

Refactor last bits of old-style build scripting #882

Conversation

theory commented Jan 3, 2025 • edited Loading

aws-amplify-us-east-1 bot commented Jan 3, 2025

theory commented Jan 3, 2025 •

edited

Loading