-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache] Don't store hop-by-hop headers #409
Comments
See also What Proxies Must Do and particularly the referenced spec |
Actual problem differs from mentioned above: hop-by-hop headers are forwarded as end-to-end headers In spec mentioned above 8 headers are marked as a hop-by-hop. But the final document RFC7230 is more strict than a draft and close to article What Proxies Must Do:
So, for request:
The Connection, Keep-Alive and both Foo headers must be removed before forwarding it. 'tfw_http_set_hdr_connection()` seems to return without updating Connection header. Also other hop-by hop headers are not removed from test messages. Used tempesta (
|
Please also store correct Server and Via headers in cache as described in #634 |
fixed in 72a24ae |
Keep-Alive and Server are hop-by-hop headers and should not be cached.
hbh_hdrs
must be adjusted and the headers must be made special to be analyzed quickly intfw_cache_copy_resp()
.Relates to #407.
The text was updated successfully, but these errors were encountered: