Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #900: Change some comments and add unit tests. #1051

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Conversation

aleksostapenko
Copy link
Contributor

No description provided.

Copy link
Contributor

@vankoven vankoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR, but an update to tempesta-test repo is required. Original issue description also described RFC violation at point 4 from Section 3.3.3, wrong status codes was sent to a client:

If this is a
       request message, the server MUST respond with a 400 (Bad Request)
       status code and then close the connection.  If this is a response
       message received by a proxy, the proxy MUST close the connection
       to the server, discard the received response, and send a 502 (Bad
       Gateway) response to the client. 

Seems like tests from long_body/test_response_wrong_length.py checks some cases of misusing Content-length headers, while others are not checked. Please, extend tests in tempesta-test repo to cover these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants