Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review comments for #1037 #1143

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Fix review comments for #1037 #1143

merged 1 commit into from
Jan 10, 2019

Conversation

krizhanovsky
Copy link
Contributor

@krizhanovsky krizhanovsky commented Jan 1, 2019

Fix usage of uninitialized valiables, wrong usage of unsigned variables, some code mess.

@ikoveshnikov the build is failed in CI because of old kernel. Could you please deploy the new kernel version?

@vankoven
Copy link
Contributor

vankoven commented Jan 9, 2019

the build is failed in CI because of old kernel. Could you please deploy the new kernel version?

Yep, just remembered about that. I'll update it today.

Copy link
Contributor

@vankoven vankoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@krizhanovsky krizhanovsky merged commit fe511ee into master Jan 10, 2019
@vankoven vankoven deleted the ak-1037-fixes branch January 11, 2019 07:23
@krizhanovsky krizhanovsky restored the ak-1037-fixes branch January 27, 2019 13:41
@krizhanovsky krizhanovsky deleted the ak-1037-fixes branch January 27, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants