Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow-up changes (see #1139) #1154

Merged
merged 1 commit into from
Jan 18, 2019
Merged

follow-up changes (see #1139) #1154

merged 1 commit into from
Jan 18, 2019

Conversation

i-rinat
Copy link
Contributor

@i-rinat i-rinat commented Jan 18, 2019

  • req->vhost is expected to be non-NULL, as it was checked before;
  • disallow multiple instances of http_post_validate at topmost level;
  • a typo.

@i-rinat
follow-up changes (see #1139)
037f92d 
* req->vhost is expected to be non-NULL, as it was checked before;
* disallow multiple instances of http_post_validate at topmost level;
* a typo.
@i-rinat i-rinat mentioned this pull request Jan 18, 2019
Merged
aleksostapenko
aleksostapenko approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@aleksostapenko aleksostapenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@i-rinat i-rinat merged commit b07d5ac into master Jan 18, 2019
@i-rinat i-rinat deleted the ri-pr1139-fixups branch January 18, 2019 19:05
@krizhanovsky krizhanovsky mentioned this pull request Jan 28, 2019
Open
@dmpetroff dmpetroff mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksostapenko aleksostapenko aleksostapenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-rinat @aleksostapenko