fix #1189: correctly fill header part of skb when writing data into p… #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankoven
force-pushed
the
ik-fill-all-skb-frags
branch
from
58d16f0 to
cdaf090
Compare
krizhanovsky
requested changes
Mar 13, 2019
tempesta_fw/ss_skb.c
Outdated
| if (!skb) | ||
| return -ENOMEM; | ||
| alloc_ldata = false; |
There was a problem hiding this comment.
There is no sense to generate more skbs if we can generate less. skb it self has large memory overhead and TCP segmentation also wins from larger skbs. It seems we can just resent it->frag to -1 instead of 0 to fix #1189.
| f_room = skb_tailroom(it->skb); | ||
| n_copy = min(c_size, f_room); | ||
| p = skb_put(it->skb, n_copy); | ||
| } |
There was a problem hiding this comment.
This is a copy&paste from tfw_msg_write() - can we reuse the code, e.g. by moving some of the code to a helper function?
…aged fragments ss_skb_frag_next() is always work with TfwMsgIter, so renamed and moved into msg.h, the whole TfwMsgIter became invalid if the function fails.
* add a new function, to allocate and add a new empty skb to current message iterator. * fix dereferences of invalid pointers in tfw_cache_build_resp_body(): it->frag may be equal to -1.
vankoven
force-pushed
the
ik-fill-all-skb-frags
branch
from
cdaf090 to
6b5e2c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aged fragments
See commit messages for the changes descriptions.