Add option for set cache policy based on cookie name or pattern #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizhanovsky
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
LGTM, but this has nothing avout #1544 . Please fix the PR message before merging to not to close the issue by the merge.
P.S. Oh, I didn't notice that this is a Draft. Sorry.
ttaym
force-pushed
the
am-1544-caching-by-cookie-name
branch
10 times, most recently
from
6f30c7d to
fbe2eb8
Compare
Fixes #1544 Signed-off-by: Aleksey Mikhaylov <[email protected]>
ttaym
force-pushed
the
am-1544-caching-by-cookie-name
branch
from
fbe2eb8 to
f68cf86
Compare
chore: fix followed PR comments
krizhanovsky
approved these changes
Feb 17, 2022
chore: fix followed PR comments
|
Updated PR. Please look at not resolved comments. |
chore: fix followed PR comments
chore: fix followed PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
PR adds new rule to http chains. Field 'cookie', field value string with prefix or postfix wildcard, forced (for now) equality sign, field argument string with prefix or postfix wildcard, action that typically should set new flag '$cache'.
The PR contains feature implementation and unit tests for http chains cookie rule. No functional tests.
Please note, that cookie field value string in
TfwHttpMatchRulefor cookie name matching is allocated string.Implemented logic works only for requests. Header
Set-Cookienot consulted.In fact only setting
$cachevariable to zero works as expected. Setting it to 1 is just leaving Tempesta FW caching logic intact.Currently in implemented logic setting
$cacheto 1 after some previous cookie rules set it to 0 will effectivelly reset it, as if it never set to zero.As side-effect
$cachesetting action is usable in other rules as well.Cookie name and value matching are case-sensitive. As i can see RFC6265#section-4.2 has no mention of case-insensitive matching (as it does for cookie attributes).
Signed-off-by: Aleksey Mikhaylov [email protected]