tfw_sched_hash: implement Highest Random Weight (Rendezvous) hashing #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdmit11
force-pushed
the
rendezvous-hashing
branch
2 times, most recently
from
c1eda11 to
7ea9443
Compare
|
Done some fixes. @krizhanovsky, please review it again. |
| @@ -515,3 +515,4 @@ tfw_addr_sa_len(const TfwAddr *addr) | |||
| validate_addr(addr); | |||
| return (addr->family == AF_INET6) ? sizeof(addr->v6) : sizeof(addr->v4); | |||
| } | |||
| EXPORT_SYMBOL(tfw_addr_sa_len); | |||
There was a problem hiding this comment.
Commented many times: do not pollute space of exported symbols names. The function is pretty short and must be moved to .h file instead of being exported.
|
The pull request is obsolete. Now these changes are the part of the iss78 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HRW hashing method allows to stick HTTP messages to their home back-end
servers, and preserve this mapping even if the number of servers is changed.
In order to achieve that, the tfw_sched_hash is updated. Now it hashes not only
HTTP requests, but also servers (TfwServer objects). For each incoming HTTP
request it searches for a best match among all server hashes.
Each Host/URI hash has only one best matching TfwSrver hash which is chosen,
and thus any request always goes to its home server unless it is offline.