Fix #235: #600
Merged
Fix #235: #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce clients hash table, now new connection just get()'s TfwClient; * Since client can have many HTTP sessions, TfwSession is introduced to handle different sticky cookies for the same client; * Now received sticky cookie is verified, so timestamp is added to cookie value; * To keep HTTP sessions persistent sticky_secret config option is introduced; * Config option sess_lifetime is also introduced to limit sessions lifetime; * Sticky cookie is just a mechanism for HTTP sessions, so http_sticky is renamed to http_sess; * tfw_addr_get_sk_saddr() was removed as doubling for ss_getpeername(); * TfwHttpMsg was replaced by TfwHttpReq and TfwHttpResp to make the logic explicit about what the arguements are; * tfw_http_prep_hexstring() is removed since there are standard bin2hex().
| if (!frang_mem_cache) { | ||
| TFW_ERR("frang: can't create cache\n"); | ||
| if (unlikely(sizeof(FrangAcc) > sizeof(TfwClassifierPrvt))) { | ||
| TFW_ERR("frang: seems miscompilation problem\n"); |
There was a problem hiding this comment.
It might be better to replace this with BUILD_BUG_ON() to run the check at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle different sticky cookies for the same client;
to http_sess;
about what the arguements are;