-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in configuration #707
Conversation
Configuration parsing error message is crucial for end-user, don't hide it behind rate limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor notes from my side, I didn't look too deeper to the changes. Review approval from @keshonok is required.
@@ -76,11 +76,19 @@ | |||
#define TFW_WARN(...) __CALLSTACK_MSG(KERN_WARNING TFW_BANNER \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to update copyright year in modified files
tempesta_fw/log.h
Outdated
@@ -76,11 +76,19 @@ | |||
#define TFW_WARN(...) __CALLSTACK_MSG(KERN_WARNING TFW_BANNER \ | |||
"Warning: " __VA_ARGS__) | |||
#define TFW_LOG(...) pr_info(TFW_BANNER __VA_ARGS__) | |||
|
|||
#define TFW_ERR_NL(...) TFW_ERR(__VA_ARGS__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"NL" isn't obvious suffix, please leave a comment like /* Not-limited printing for .... */
Change log:
for configuration: