Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in configuration #707

Merged
merged 4 commits into from
Mar 17, 2017
Merged

Fix errors in configuration #707

merged 4 commits into from
Mar 17, 2017

Conversation

vankoven
Copy link
Contributor

Change log:

[18638.202740] [tempesta] ERROR: invalid number of values; expected: 1, got: 0
[18638.204503] [tempesta] ERROR: Unable to parse 'listen' value: 'No value specified'
[18638.206276] [tempesta] ERROR: configuration parsing error:
                  5: listen; # 80;
                     ^^^^^^^^^^^^^
[18638.208295] [tempesta] ERROR: failed to start modules

for configuration:

cache 0;
listen 80;
server 127.0.0.1:8080;
# some comment here
listen; # 80;
# some comment here
# some comment here
# some comment here
# some comment here
# some comment here

Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor notes from my side, I didn't look too deeper to the changes. Review approval from @keshonok is required.

@@ -76,11 +76,19 @@
#define TFW_WARN(...) __CALLSTACK_MSG(KERN_WARNING TFW_BANNER \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to update copyright year in modified files

@@ -76,11 +76,19 @@
#define TFW_WARN(...) __CALLSTACK_MSG(KERN_WARNING TFW_BANNER \
"Warning: " __VA_ARGS__)
#define TFW_LOG(...) pr_info(TFW_BANNER __VA_ARGS__)

#define TFW_ERR_NL(...) TFW_ERR(__VA_ARGS__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"NL" isn't obvious suffix, please leave a comment like /* Not-limited printing for .... */

@vankoven vankoven merged commit d25813d into master Mar 17, 2017
@vankoven vankoven deleted the ik-fix-cfg branch March 17, 2017 16:20
@vankoven vankoven restored the ik-fix-cfg branch March 22, 2017 10:09
@vankoven vankoven deleted the ik-fix-cfg branch March 22, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants