Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #692 #757

Merged
merged 32 commits into from
Jul 16, 2017
Merged

Fix #692 #757

merged 32 commits into from
Jul 16, 2017

Conversation

krizhanovsky
Copy link
Contributor

This is unfinished work on #692, I still see crashes in tcp_clean_rtx_queue().

krizhanovsky added 10 commits May 28, 2017 21:29
@krizhanovsky
Fix #692 (comment): do not try to lock a locked socket; remove redund…
ed6ae06 
…ant comments - that is OK to close a socket several times in unlikely case
@krizhanovsky
Default Apache and Nginx configurations frequently reset connections,…
132b362 
… so disable "unable to find a backed server" warnings
@krizhanovsky
#692 (comment): fix lockdep warning: there is no dependency between r…
649eca9 
…et_qlock and the socket lock, the first one is absolutely harmless
@krizhanovsky
#692 (comment): tfw_http_conn_release() can be called from user conte…
805cca7 
…xt, so disable softirq on fwd_qlock locking
@krizhanovsky
Fix #692 (comment): do not try to lock a locked socket; remove redund…
2b98849 
…ant comments - that is OK to close a socket several times in unlikely case
@krizhanovsky
Default Apache and Nginx configurations frequently reset connections,…
4a7f060 
… so disable "unable to find a backed server" warnings
@krizhanovsky
#692 (comment): fix lockdep warning: there is no dependency between r…
841f081 
…et_qlock and the socket lock, the first one is absolutely harmless
@krizhanovsky
#692 (comment): tfw_http_conn_release() can be called from user conte…
b7b8b1f 
…xt, so disable softirq on fwd_qlock locking
@krizhanovsky
Merge branch 'ak-692' of github.com:tempesta-tech/tempesta into ak-692
7ca954b
@krizhanovsky
Use the proper marker that we are in softirq
205e7a1
keshonok
keshonok approved these changes Jun 26, 2017
View reviewed changes
Copy link
Contributor

@keshonok keshonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@krizhanovsky krizhanovsky mentioned this pull request Jun 30, 2017
Closed
krizhanovsky added 12 commits July 1, 2017 16:15
@krizhanovsky
Fix #692 (comment): do not try to lock a locked socket; remove redund…
4cb1dbf 
…ant comments - that is OK to close a socket several times in unlikely case
@krizhanovsky
Default Apache and Nginx configurations frequently reset connections,…
afb1c5c 
… so disable "unable to find a backed server" warnings
@krizhanovsky
#692 (comment): fix lockdep warning: there is no dependency between r…
fba6e46 
…et_qlock and the socket lock, the first one is absolutely harmless
@krizhanovsky
#692 (comment): tfw_http_conn_release() can be called from user conte…
b0a805e 
…xt, so disable softirq on fwd_qlock locking
@krizhanovsky
Use the proper marker that we are in softirq
9f3ef89
@krizhanovsky
Small kernel hardening: disable preemption in skb page allocator as w…
571264a 
…ell softirqs
@krizhanovsky
put_page() calls compund head, so put_page(virt_to_head_page()) gets …
1cadd5b 
…head page twice
@krizhanovsky
Properly implement wrong commit 2b98849; fix #668 - ss_sock_cpu_check…
f1a36a3 
…() should be removed
@krizhanovsky
Merge branch 'ak-692' of github.com:tempesta-tech/tempesta into ak-692
44e8b6f
@krizhanovsky
GCC 6: fix warning about uninitialized variables
61cf994
@krizhanovsky
Fix #668: there are no more bad socket warnings, see f1a36a3
a381cb6
@krizhanovsky
Move to Linux 4.9.35
c2b5c53
@krizhanovsky krizhanovsky mentioned this pull request Jul 2, 2017
Closed
@keshonok keshonok force-pushed the ak-692 branch 2 times, most recently from dcaf224 to d2f862e Compare July 14, 2017 21:31
@keshonok
Protect repair actions on srv_conn->fwd_queue with a lock.
a33dfe6 
The goal is to protect repair actions against a potential race
condition with the same connection coming live on another CPU.
@krizhanovsky krizhanovsky merged commit 2d99aa5 into master Jul 16, 2017
@keshonok keshonok deleted the ak-692 branch July 18, 2017 09:04
@keshonok keshonok restored the ak-692 branch July 19, 2017 15:02
@krizhanovsky krizhanovsky deleted the ak-692 branch July 26, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshonok keshonok keshonok approved these changes

@vankoven vankoven Awaiting requested review from vankoven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krizhanovsky @keshonok