Update return codes on message parsing errors. #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
502 status code indicates that gateway or proxy received an invalid response from an inbound server. See RFC 7231 Section 6.6.3. 400 status code indicates a client error (e.g., malformed request syntax, invalid request message framing, or deceptive request routing). See RFC 7231 Section 6.5.1. Note, that frang module can block responses and requests, but such blocks shouldn't be confused for parsing errors. If request was filtered out by frang, the 403 status code must be returned. If response was filtered out, then the same 502 status code must be returned.
krizhanovsky
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
502 status code indicates that gateway or proxy received an
invalid response from an inbound server. See RFC 7231 Section 6.6.3.
400 status code indicates a client error (e.g., malformed request
syntax, invalid request message framing, or deceptive request routing).
See RFC 7231 Section 6.5.1.
Note, that frang module can block responses and requests, but such
blocks shouldn't be confused for parsing errors. If request was
filtered out by frang, the 403 status code must be returned. If
response was filtered out, then the same 502 status code must be
returned.
Although the patch closes issue described in #900, more work (as fixing up content-length header) is required in #900.