Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interceptors examples #40

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add interceptors examples #40

merged 4 commits into from
Nov 15, 2023

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Oct 19, 2023 •
edited
Loading

What was changed

Add interceptors example with:

  • request logger
  • activity attributed options applyer

Why?

Need to demonstrate how to write custom interceptors

Checklist

@roxblnfk
Add interceptors example with:
dbc50e8 
- request logger
- activity attributed options applier
@roxblnfk roxblnfk changed the title Add interceptors example with: Add interceptors examples Oct 19, 2023
@roxblnfk roxblnfk mentioned this pull request Oct 23, 2023
Merged
@wolfy-j wolfy-j requested a review from flossypurse November 15, 2023 18:25
@roxblnfk roxblnfk marked this pull request as ready for review November 15, 2023 18:56
Sushisource
Sushisource approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Reading from attributes is neat.

app/src/Interceptors/Interceptor/ActivityAttributesInterceptor.php Outdated Show resolved Hide resolved
@roxblnfk roxblnfk merged commit e8a1497 into temporalio:master Nov 15, 2023
1 check passed
@roxblnfk roxblnfk deleted the interceptors-sample branch November 15, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@flossypurse flossypurse Awaiting requested review from flossypurse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interceptors sample
2 participants
@roxblnfk @Sushisource