Workflow completion command reordering (#270)

Fixes #249
temporalio · Jun 11, 2024 · 3c6c7ac · 3c6c7ac
1 parent c299cec
commit 3c6c7ac
Show file tree

Hide file tree

Showing 12 changed files with 266 additions and 189 deletions.
diff --git a/src/Temporalio/Bridge/Cargo.lock b/src/Temporalio/Bridge/Cargo.lock
diff --git a/src/Temporalio/Bridge/sdk-core b/src/Temporalio/Bridge/sdk-core
diff --git a/src/Temporalio/Worker/TemporalWorker.cs b/src/Temporalio/Worker/TemporalWorker.cs
@@ -89,7 +89,8 @@ public TemporalWorker(IWorkerClient client, TemporalWorkerOptions options)
                     OnTaskStarting: options.OnTaskStarting,
                     OnTaskCompleted: options.OnTaskCompleted,
                     RuntimeMetricMeter: MetricMeter,
-                    WorkerLevelFailureExceptionTypes: options.WorkflowFailureExceptionTypes));
+                    WorkerLevelFailureExceptionTypes: options.WorkflowFailureExceptionTypes,
+                    DisableCompletionCommandReordering: options.DisableWorkflowCompletionCommandReordering));
             }
         }
 

diff --git a/src/Temporalio/Worker/TemporalWorkerOptions.cs b/src/Temporalio/Worker/TemporalWorkerOptions.cs
@@ -286,6 +286,15 @@ public TemporalWorkerOptions()
         internal Func<WorkflowInstanceDetails, IWorkflowInstance> WorkflowInstanceFactory { get; set; } =
             DefaultWorkflowInstanceFactory;
 
+        /// <summary>
+        /// Gets or sets a value indicating whether the workflow completion command reordering will
+        /// apply.
+        /// </summary>
+        /// <remarks>
+        /// This is visible for testing only.
+        /// </remarks>
+        internal bool DisableWorkflowCompletionCommandReordering { get; set; }
+
         /// <summary>
         /// Add the given delegate with <see cref="ActivityAttribute" /> as an activity. This is
         /// usually a method reference.
+16 −6		client/src/retry.rs
+2 −3		core/Cargo.toml
+63 −5		core/src/core_tests/workflow_tasks.rs
+48 −40		core/src/worker/workflow/machines/workflow_machines.rs