Skip to content

Commit

Permalink
Add rule code and edit signal warning (#317)
Browse files Browse the repository at this point in the history
  • Loading branch information
dandavison authored Aug 6, 2024
1 parent 62da5d6 commit 66574bd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Temporalio/Worker/WorkflowInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2264,13 +2264,13 @@ private class Handlers : LinkedList<Handlers.Handler>
LoggerMessage.Define<string, WarnableSignals>(
LogLevel.Warning,
0,
"Workflow {Id} finished while signal handlers are still running. This may " +
"[TMPRL1102] Workflow {Id} finished while signal handlers are still running. This may " +
"have interrupted work that the signal handler was doing. You can wait for " +
"all update and signal handlers to complete by using `await " +
"Workflow.WaitConditionAsync(() => Workflow.AllHandlersFinished)`. " +
"Alternatively, if both you and the clients sending the signal are okay with " +
"interrupting running handlers when the workflow finishes, and causing " +
"clients to receive errors, then you can disable this warning via the signal " +
"interrupting running handlers when the workflow finishes, " +
"then you can disable this warning via the signal " +
"handler attribute: " +
"`[WorkflowSignal(UnfinishedPolicy=HandlerUnfinishedPolicy.Abandon)]`. The " +
"following signals were unfinished (and warnings were not disabled for their " +
Expand All @@ -2280,7 +2280,7 @@ private class Handlers : LinkedList<Handlers.Handler>
LoggerMessage.Define<string, WarnableUpdates>(
LogLevel.Warning,
0,
"Workflow {Id} finished while update handlers are still running. This may " +
"[TMPRL1102] Workflow {Id} finished while update handlers are still running. This may " +
"have interrupted work that the update handler was doing, and the client " +
"that sent the update will receive a 'workflow execution already completed' " +
"RpcException instead of the update result. You can wait for all update and " +
Expand Down

0 comments on commit 66574bd

Please sign in to comment.