Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Signals that can't be deserialized should be dropped/ignored #105

Closed
cretz opened this issue Jul 13, 2023 · 0 comments · Fixed by #114
Closed

[Bug] Signals that can't be deserialized should be dropped/ignored #105

cretz opened this issue Jul 13, 2023 · 0 comments · Fixed by #114
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jul 13, 2023

Describe the bug

In Go and Java we drop signals whose args can't be deserialized, we should here too.
@cretz cretz added the bug Something isn't working label Jul 13, 2023
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Jul 19, 2023
@cretz
Log and drop signals when we can't decode the arguments
f6ec1ab 
Fixes temporalio#105
@cretz cretz mentioned this issue Jul 19, 2023
Merged
cretz added a commit that referenced this issue Jul 20, 2023
@cretz
Log and drop signals when we can't decode the arguments (#114)
1c14789 
Fixes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log and drop signals when we can't decode the arguments cretz/temporal-sdk-dotnet
1 participant
@cretz