Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Make StartUpdateAsync users aware that it's synchronous w/ worker. #231

Closed
drewhoskins-temporal opened this issue Apr 25, 2024 · 0 comments · Fixed by #251
Closed

[Feature Request] Make StartUpdateAsync users aware that it's synchronous w/ worker. #231

drewhoskins-temporal opened this issue Apr 25, 2024 · 0 comments · Fixed by #251
Labels
enhancement New feature or request

Comments

@drewhoskins-temporal
Copy link

Is your feature request related to a problem? Please describe.

See temporalio/features#469

Describe the solution you'd like

sdk-dotnet/src/Temporalio/Client/WorkflowHandle.cs

Line 313 in 2bd9ed3

public Task<WorkflowUpdateHandle> StartUpdateAsync<TWorkflow>(

wait stage shouldn't be optional here, and docs should clarify availability.

Additional context
@drewhoskins-temporal drewhoskins-temporal added the enhancement New feature or request label Apr 25, 2024
@drewhoskins-temporal drewhoskins-temporal changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] Make StartWorkflowAsync users aware that it's synchronous w/ worker. Apr 25, 2024
Closed
8 tasks
@cretz cretz changed the title [Feature Request] Make StartWorkflowAsync users aware that it's synchronous w/ worker. [Feature Request] Make StartUpdateAsync users aware that it's synchronous w/ worker. Apr 25, 2024
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue May 21, 2024
@cretz
Required wait update stage and polling improvements
7c56079 
Fixes temporalio#198
Fixes temporalio#199
Fixes temporalio#231
@cretz cretz mentioned this issue May 21, 2024
Merged
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue May 21, 2024
@cretz
Required wait update stage and polling improvements
4849264 
Fixes temporalio#198
Fixes temporalio#199
Fixes temporalio#231
@cretz cretz closed this as completed in 618e878 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Required wait update stage and polling improvements cretz/temporal-sdk-dotnet
1 participant
@drewhoskins-temporal