Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker poller and ratio options #200

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Worker poller and ratio options #200

merged 2 commits into from
Mar 7, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Mar 6, 2024

What was changed

Expose MaxConcurrentWorkflowTaskPolls, NonStickyToStickyPollRatio, and MaxConcurrentActivityTaskPolls. There's not an easy/good way to test, though if really wanted, I can make a test that checks metrics to confirm poller count goes up (would need to check how it reaches "max").

Checklist

  1. Closes [Feature Request] Expose max poller options for workers #196

@cretz cretz requested a review from a team March 6, 2024 21:41
mjameswh
mjameswh approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cretz cretz merged commit ce3f195 into temporalio:main Mar 7, 2024
6 checks passed
@cretz cretz deleted the max-poller-config branch March 7, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjameswh mjameswh mjameswh approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose max poller options for workers
3 participants
@cretz @Sushisource @mjameswh