Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-12 GHA runners instead of macos-latest #232

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mjameswh
Copy link
Contributor

What was changed

  • In CI, use macos-12 GHA runners instead of macos-latest, as `macos

Why?

  • GitHub Action’s runner macos-latest has just been updated to point to macos-14, which are M1-based machines, rather than macos-12, which were x64-based machines.

This is a breaking change at this time, as there is no binary distribution of protoc 3.x for that architecture.

```
Run arduino/setup-protoc@v1
Getting protoc version: v3.20.3
Downloading archive: https://github.com/protocolbuffers/protobuf/releases/download/v3.20.3/protoc-3.20.3-osx-aarch_64.zip
Error: Error: Failed to download version v3.20.3: Error, Unexpected HTTP response: 404 - 404
```

@cretz
Copy link
Member

cretz commented Apr 25, 2024

Thanks!

There is an open issue at #210, and we should support both Intel and ARM mac (same as temporalio/sdk-python#506) and test both and build packages on both. Right now we only test on one and use cross-compilation for build with no smoke test for this version.

But this is a good stopgap to get over whatever just changed. Also there's a build-binaries GH thing that has to be fixed too probably. Unsure if I can change branch protection on this yet, will see.

@mjameswh
Copy link
Contributor Author

@cretz I modified required checks to include macos-12 instead of macos-latest. We'll need to update that again once we implement the correct solution.

@mjameswh mjameswh merged commit 9c1c127 into main Apr 25, 2024
6 checks passed
@mjameswh mjameswh deleted the broken-macos-latest-runner branch April 25, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants